Handle NULL typeface in SkFontMgr_fontconfig::onMatchFaceStyle.

Handle NULL typeface in SkFontMgr_fontconfig::onMatchFaceStyle.

SampleApp does this, and it needs to be handled properly.

Committed: https://skia.googlesource.com/skia/+/9db509272a6fa2badbbdd2f5afce827370960a5f

[bungeman-skia, 2014-09-12 18:44:59]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-09-12 18:55:27]

https://codereview.chromium.org/563263003/diff/1/src/ports/SkFontMgr_fontconf...
File src/ports/SkFontMgr_fontconfig.cpp (right):

https://codereview.chromium.org/563263003/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:801: const char* name = NULL;
not ""?

[bungeman-skia, 2014-09-12 19:02:32]

https://codereview.chromium.org/563263003/diff/1/src/ports/SkFontMgr_fontconf...
File src/ports/SkFontMgr_fontconfig.cpp (right):

https://codereview.chromium.org/563263003/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:801: const char* name = NULL;
On 2014/09/12 18:55:27, mtklein wrote:
> not ""?

Yeah, I want no-name not empty-name here. In theory you could have a font with
an empty name. In fact, I've seen one in the wild (it was trying to be sneaky
and have a valid but empty name to prevent people from installing it locally).
NULL means 'default font' or 'I don't care what the name is'.

[mtklein, 2014-09-12 19:06:09]

The CQ bit was checked by mtklein@google.com

[mtklein, 2014-09-12 19:06:10]

lgtm

[commit-bot: I haz the power, 2014-09-12 19:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563263003/1

[commit-bot: I haz the power, 2014-09-12 19:14:18]

Committed patchset #1 (id:1) as 9db509272a6fa2badbbdd2f5afce827370960a5f