Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 563263002: Cleanup: cpplint from /extensions (Closed)

Created:
6 years, 3 months ago by limasdf
Modified:
6 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: cpplint from /extensions * Fix wrong header guard. * Remove or add explicit constructor * Remove unwanted semicolon BUG=None Committed: https://crrev.com/d70dc5ae4aac6fc6d9b8af7ad57776e76ea765ce Cr-Commit-Position: refs/heads/master@{#294700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M extensions/browser/error_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/granted_file_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mock_extension_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/script_execution_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/script_executor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/test_extension_registry_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/test_runtime_api_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/uninstall_reason.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/update_manifest.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/url_pattern_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M extensions/renderer/default_dispatcher_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
limasdf
Please take a look. this is just simple mechanical change.
6 years, 3 months ago (2014-09-12 15:22:09 UTC) #2
Devlin
Awesome, lgtm!
6 years, 3 months ago (2014-09-12 22:47:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563263002/1
6 years, 3 months ago (2014-09-12 22:54:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d5cd30f32584954b2758cb52c2e5aaf59bf097f5
6 years, 3 months ago (2014-09-13 00:03:15 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:13:59 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d70dc5ae4aac6fc6d9b8af7ad57776e76ea765ce
Cr-Commit-Position: refs/heads/master@{#294700}

Powered by Google App Engine
This is Rietveld 408576698