Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 563253002: Support 'loop' atribute on fake video element for casting (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support 'loop' atribute on fake video element for casting BUG=413006 TEST=manually tested Committed: https://crrev.com/b27b2bd22bf6ee984f3d9adf47369527298ae158 Cr-Commit-Position: refs/heads/master@{#294761}

Patch Set 1 #

Patch Set 2 : Add a JSdoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-12 14:19:10 UTC) #2
fukino
On 2014/09/12 14:19:10, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.
6 years, 3 months ago (2014-09-12 15:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563253002/20001
6 years, 3 months ago (2014-09-14 03:38:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 06053a1b88b541c6f6c83e6e89bbbb9545c1634f
6 years, 3 months ago (2014-09-14 05:27:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-14 05:31:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b27b2bd22bf6ee984f3d9adf47369527298ae158
Cr-Commit-Position: refs/heads/master@{#294761}

Powered by Google App Engine
This is Rietveld 408576698