public/platform/WebThread.h - Issue 563203002: [Blink-WebWorkers] WorkerSharedTimer cancels extra delayed tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebThread.h

Issue 563203002: [Blink-WebWorkers] WorkerSharedTimer cancels extra delayed tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed hash set, which was used to store previous tasks. Now using single ptr. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebThread.h

diff --git a/public/platform/WebThread.h b/public/platform/WebThread.h

index 6bee10fbfebd929305b7c94031e4bf87e545f79b..a7705852b61640737bb373a17b014aeff50a54e9 100644

--- a/public/platform/WebThread.h

+++ b/public/platform/WebThread.h

@@ -26,6 +26,7 @@

#define WebThread_h

#include "WebCommon.h"

+#include "base/memory/weak_ptr.h"

jochen (gone - plz use gerrit) 2014/09/12 14:11:54 you can't use base from blink, there is wtf/WeakPt

namespace blink {

@@ -53,6 +54,7 @@ public:

// thread.

virtual void postTask(Task*) = 0;

virtual void postDelayedTask(Task*, long long delayMs) = 0;

+ virtual void postCancellableDelayedTask(base::WeakPtrFactory<Task>& task, long long delayMs) { }

virtual bool isCurrentThread() const = 0;

« no previous file with comments | « Source/core/workers/WorkerThread.cpp ('k') | no next file » | no next file with comments »