CDM FileIOTest: Explictly test corrupted file.

media/cdm/ppapi/cdm_file_io_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cdm/ppapi/cdm_file_io_test.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/logging.h"
 
@@ skipping 57 matching lines @@
 
 FileIOTestRunner::FileIOTestRunner(const CreateFileIOCB& create_file_io_cb)
     : create_file_io_cb_(create_file_io_cb),
       total_num_tests_(0),
       num_passed_tests_(0) {
   // Generate |large_data_|.
   large_data_.resize(kLargeDataSize);
   for (size_t i = 0; i < kLargeDataSize; ++i)
     large_data_[i] = i % kuint8max;
 
+  // Generate |corrupted_big_data_|.

[ddorwin, 2014/09/12 20:25:24]

Do we really need a member for one test?

[xhwang, 2014/09/13 01:19:30]

We add test cases first then run all tests together. So the data to be expected
must be valid throughout the lifetime of this class.

Naming is hard...

+  corrupted_big_data_.assign(kData, kData + kDataSize);

[ddorwin, 2014/09/12 20:25:24]

I don't think the naming is right. It is data but larger. Difficult naming is
another reason not to have a non-local variable.

[xhwang, 2014/09/13 01:19:30]

Acknowledged.

+  corrupted_big_data_.resize(kBigDataSize, 0);
+
   AddTests();
 }
 
 FileIOTestRunner::~FileIOTestRunner() {
   if (remaining_tests_.empty())
     return;
 
   DCHECK_LT(num_passed_tests_, total_num_tests_);
   FILE_IO_DVLOG(1) << "Not Finished (probably due to timeout). "
                    << num_passed_tests_ << " passed in "
@@ skipping 172 matching lines @@
     CLOSE_FILE
   END_TEST_CASE
 
   START_TEST_CASE("CloseDuringPendingWrite")
     OPEN_FILE
     EXPECT_FILE_OPENED(kSuccess)
     WRITE_FILE(kData, kDataSize)
     CLOSE_FILE
   END_TEST_CASE
 
+  START_TEST_CASE("CloseDuringPendingOverwriteWithLargerData")
+    OPEN_FILE
+    EXPECT_FILE_OPENED(kSuccess)
+    WRITE_FILE(kData, kDataSize)
+    EXPECT_FILE_WRITTEN(kSuccess)
+    WRITE_FILE(kBigData, kBigDataSize)
+    CLOSE_FILE
+    // The file is corrupted. See http://crbug.com/410630
+    CREATE_FILE_IO
+    OPEN_FILE
+    EXPECT_FILE_OPENED(kSuccess)
+    READ_FILE
+    EXPECT_FILE_READ(kSuccess, &corrupted_big_data_[0], kBigDataSize)
+  END_TEST_CASE
+
+  START_TEST_CASE("CloseDuringPendingOverwriteWithSmallerData")
+    OPEN_FILE
+    EXPECT_FILE_OPENED(kSuccess)
+    WRITE_FILE(kBigData, kBigDataSize)
+    EXPECT_FILE_WRITTEN(kSuccess)
+    WRITE_FILE(kData, kDataSize)
+    CLOSE_FILE
+    // The file is corrupted. See http://crbug.com/410630
+    CREATE_FILE_IO
+    OPEN_FILE
+    EXPECT_FILE_OPENED(kSuccess)
+    READ_FILE
+    EXPECT_FILE_READ(kSuccess, kBigData, kDataSize)
+  END_TEST_CASE
+
   START_TEST_CASE("CloseDuringPendingRead")
     OPEN_FILE
     EXPECT_FILE_OPENED(kSuccess)
     WRITE_FILE(kData, kDataSize)
     EXPECT_FILE_WRITTEN(kSuccess)
     READ_FILE
     CLOSE_FILE
+    // Make sure the file is not modified.
+    CREATE_FILE_IO
+    OPEN_FILE
+    EXPECT_FILE_OPENED(kSuccess)
+    READ_FILE
+    EXPECT_FILE_READ(kSuccess, kData, kDataSize)
   END_TEST_CASE
 }
 
 void FileIOTestRunner::RunAllTests(const CompletionCB& completion_cb) {
   completion_cb_ = completion_cb;
   total_num_tests_ = remaining_tests_.size();
   RunNextTest();
 }
 
 void FileIOTestRunner::RunNextTest() {
@@ skipping 158 matching lines @@
 void FileIOTest::OnTestComplete(bool success) {
   while (!file_io_stack_.empty()) {
     file_io_stack_.top()->Close();
     file_io_stack_.pop();
   }
   FILE_IO_DVLOG(3) << test_name_ << (success ? " PASSED" : " FAILED");
   base::ResetAndReturn(&completion_cb_).Run(success);
 }
 
 }  // namespace media