Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Side by Side Diff: PRESUBMIT.py

Issue 563173002: Cleanup: Use base/files/file_util.h instead of base/file_util.h in [c-n]*/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/app_mode/kiosk_external_updater.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" 924 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]"
925 r"startup_browser_creator\.cc$", 925 r"startup_browser_creator\.cc$",
926 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", 926 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*",
927 r"chrome[\\\/]browser[\\\/]diagnostics[\\\/]" + 927 r"chrome[\\\/]browser[\\\/]diagnostics[\\\/]" +
928 r"diagnostics_writer\.cc$", 928 r"diagnostics_writer\.cc$",
929 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$", 929 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$",
930 r"^chromecast[\\\/]", 930 r"^chromecast[\\\/]",
931 r"^cloud_print[\\\/]", 931 r"^cloud_print[\\\/]",
932 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" 932 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]"
933 r"gl_helper_benchmark\.cc$", 933 r"gl_helper_benchmark\.cc$",
934 r"^courgette[\\\/]courgette_tool\.cc$",
934 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", 935 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$",
935 r"^native_client_sdk[\\\/]", 936 r"^native_client_sdk[\\\/]",
936 r"^remoting[\\\/]base[\\\/]logging\.h$", 937 r"^remoting[\\\/]base[\\\/]logging\.h$",
937 r"^remoting[\\\/]host[\\\/].*", 938 r"^remoting[\\\/]host[\\\/].*",
938 r"^sandbox[\\\/]linux[\\\/].*", 939 r"^sandbox[\\\/]linux[\\\/].*",
939 r"^tools[\\\/]", 940 r"^tools[\\\/]",
940 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$", 941 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",
941 r"^webkit[\\\/]browser[\\\/]fileapi[\\\/]" + 942 r"^webkit[\\\/]browser[\\\/]fileapi[\\\/]" +
942 r"dump_file_system.cc$",)) 943 r"dump_file_system.cc$",))
943 source_file_filter = lambda x: input_api.FilterSourceFile( 944 source_file_filter = lambda x: input_api.FilterSourceFile(
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 builders.extend(['cros_x86']) 1589 builders.extend(['cros_x86'])
1589 1590
1590 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1591 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1591 # unless they're .gyp(i) files as changes to those files can break the gyp 1592 # unless they're .gyp(i) files as changes to those files can break the gyp
1592 # step on that bot. 1593 # step on that bot.
1593 if (not all(re.search('^chrome', f) for f in files) or 1594 if (not all(re.search('^chrome', f) for f in files) or
1594 any(re.search('\.gypi?$', f) for f in files)): 1595 any(re.search('\.gypi?$', f) for f in files)):
1595 builders.extend(['android_aosp']) 1596 builders.extend(['android_aosp'])
1596 1597
1597 return GetDefaultTryConfigs(builders) 1598 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/app_mode/kiosk_external_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698