Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 563143005: Revert of Move ChangeVersionWrapper destructor out of line. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
michaeln, Reid Kleckner
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Project:
blink
Visibility:
Public.

Description

Revert of Move ChangeVersionWrapper destructor out of line. (patchset #1 id:1 of https://codereview.chromium.org/572343002/) Reason for revert: No longer needed, we fixed this in clang instead (see BUG=). Original issue's description: > Move ChangeVersionWrapper destructor out of line. > > With clang/win, the vtable of ChangeVersionWrapper ends up being referenced > for some reason, which causes the destructor to be defined, which requires > a definition of SQLErrorData. So move the destructor out of line, where > the definition is available. > > BUG=413478 > R=michaeln@chromium.org, rnk@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182093 TBR=rnk@chromium.org,michaeln@chromium.org NOTREECHECKS=true NOTRY=true BUG=413478 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182124

Patch Set 1 #

Patch Set 2 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/modules/webdatabase/ChangeVersionWrapper.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/ChangeVersionWrapper.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Created Revert of Move ChangeVersionWrapper destructor out of line.
6 years, 3 months ago (2014-09-17 00:03:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563143005/1
6 years, 3 months ago (2014-09-17 00:03:52 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/modules/webdatabase/ChangeVersionWrapper.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-17 00:04:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563143005/70001
6 years, 3 months ago (2014-09-17 00:06:45 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:07:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as 182124

Powered by Google App Engine
This is Rietveld 408576698