Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: src/shared/ppapi_proxy/plugin_ppp_impl.cc

Issue 5631003: ppapi_proxy: Make DebugPrintf more usable.... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/shared/ppapi_proxy/plugin_instance.cc ('k') | src/shared/ppapi_proxy/plugin_var.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/shared/ppapi_proxy/plugin_ppp_impl.cc
===================================================================
--- src/shared/ppapi_proxy/plugin_ppp_impl.cc (revision 3872)
+++ src/shared/ppapi_proxy/plugin_ppp_impl.cc (working copy)
@@ -50,7 +50,6 @@
bool StartUpcallSrpcChannel(NaClSrpcImcDescType upcall_channel_desc) {
// Create the upcall srpc client.
if (upcall_channel_desc == -1) {
- DebugPrintf(" Bad upcall_channel_desc\n");
return false;
}
NaClSrpcChannel* upcall_channel = reinterpret_cast<NaClSrpcChannel*>(
@@ -89,16 +88,18 @@
int32_t* success) {
NaClSrpcClosureRunner runner(done);
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
- DebugPrintf("PPP_InitializeModule: %s\n", service_description);
+ DebugPrintf("Plugin::PPP_InitializeModule: %s\n", service_description);
// Set up the service for calling back into the browser.
if (!StartMainSrpcChannel(const_cast<const char*>(service_description),
rpc->channel)) {
- DebugPrintf(" Failed to export service on main channel\n");
+ DebugPrintf("Plugin::PPP_InitializeModule: "
+ "failed to export service on main channel\n");
return;
}
// Set up the upcall channel for calling back into the browser.
if (!StartUpcallSrpcChannel(upcall_channel_desc)) {
- DebugPrintf(" Failed to construct upcall channel\n");
+ DebugPrintf("Plugin::PPP_InitializeModule: "
+ "failed to construct upcall channel\n");
StopMainSrpcChannel();
return;
}
@@ -112,7 +113,7 @@
NaClSrpcClosure* done) {
NaClSrpcClosureRunner runner(done);
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
- DebugPrintf("PPP_ShutdownModule\n");
+ DebugPrintf("Plugin::PPP_ShutdownModule\n");
::PPP_ShutdownModule();
ppapi_proxy::UnsetModuleIdForSrpcChannel(rpc->channel);
StopUpcallSrpcChannel();
@@ -126,7 +127,7 @@
int32_t* exports_interface_name) {
NaClSrpcClosureRunner runner(done);
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
- DebugPrintf("PPP_GetInterface(%s)\n", interface_name);
+ DebugPrintf("Plugin::PPP_GetInterface(%s)\n", interface_name);
// Since the proxy will make calls to proxied interfaces, we need simply
// to know whether the plugin exports a given interface.
const void* plugin_interface = ::PPP_GetInterface(interface_name);
« no previous file with comments | « src/shared/ppapi_proxy/plugin_instance.cc ('k') | src/shared/ppapi_proxy/plugin_var.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698