Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: src/shared/ppapi_proxy/browser_ppp.cc

Issue 5631003: ppapi_proxy: Make DebugPrintf more usable.... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/shared/ppapi_proxy/browser_instance.cc ('k') | src/shared/ppapi_proxy/browser_upcall.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/shared/ppapi_proxy/browser_ppp.cc
===================================================================
--- src/shared/ppapi_proxy/browser_ppp.cc (revision 3872)
+++ src/shared/ppapi_proxy/browser_ppp.cc (working copy)
@@ -29,7 +29,7 @@
PP_Module module_id,
PPB_GetInterface get_browser_interface,
PP_Instance instance) {
- DebugPrintf("BrowserPpp::InitializeModule(%"NACL_PRIu64", %p)\n",
+ DebugPrintf("Browser::PPP_InitializeModule(%"NACL_PRIu64", %p)\n",
module_id, get_browser_interface);
SetBrowserGetInterface(get_browser_interface);
SetBrowserPppForInstance(instance, this);
@@ -42,11 +42,13 @@
NaClSrpcService* service = reinterpret_cast<NaClSrpcService*>(
calloc(1, sizeof(*service)));
if (NULL == service) {
- DebugPrintf("Couldn't create callback services.\n");
+ DebugPrintf("Browser::PPP_InitializeModule: "
+ "could not create callback services.\n");
return PP_ERROR_FAILED;
}
if (!NaClSrpcServiceHandlerCtor(service, PpbRpcs::srpc_methods)) {
- DebugPrintf("Couldn't construct callback services.\n");
+ DebugPrintf("Browser::PPP_InitializeModule: "
+ "could not construct callback services.\n");
free(service);
return PP_ERROR_FAILED;
}
@@ -66,33 +68,33 @@
&plugin_pid_,
&success);
if (retval != NACL_SRPC_RESULT_OK) {
- DebugPrintf("InitializeModule failed %02x\n", retval);
+ DebugPrintf("Browser::PPP_InitializeModule failed %02x\n", retval);
return PP_ERROR_FAILED;
}
- DebugPrintf("InitializeModule succeeded %02x\n", success);
+ DebugPrintf("Browser::PPP_InitializeModule succeeded %02x\n", success);
return success;
}
void BrowserPpp::ShutdownModule() {
- DebugPrintf("BrowserPpp::ShutdownModule\n");
+ DebugPrintf("Browser::PPP_ShutdownModule\n");
PppRpcClient::PPP_ShutdownModule(channel_);
NaClThreadJoin(&upcall_thread_);
UnsetModuleIdForSrpcChannel(channel_);
}
const void* BrowserPpp::GetInterface(const char* interface_name) {
- DebugPrintf("BrowserPpp::GetInterface('%s')\n", interface_name);
+ DebugPrintf("Browser::PPP_GetInterface('%s')\n", interface_name);
int32_t exports_interface_name;
NaClSrpcError retval =
PppRpcClient::PPP_GetInterface(channel_,
const_cast<char*>(interface_name),
&exports_interface_name);
if (retval != NACL_SRPC_RESULT_OK || !exports_interface_name) {
- DebugPrintf(" Interface '%s' not supported\n", interface_name);
+ DebugPrintf("Browser::PPP_GetInterface: '%s' not found\n", interface_name);
return NULL;
}
if (strcmp(interface_name, PPP_INSTANCE_INTERFACE) == 0) {
- DebugPrintf(" Interface '%s' proxied\n", interface_name);
+ DebugPrintf("Browser::PPP_GetInterface: '%s' proxied\n", interface_name);
return reinterpret_cast<const void*>(BrowserInstance::GetInterface());
}
// TODO(sehr): other interfaces go here.
« no previous file with comments | « src/shared/ppapi_proxy/browser_instance.cc ('k') | src/shared/ppapi_proxy/browser_upcall.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698