Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5631003: ppapi_proxy: Make DebugPrintf more usable.... (Closed)

Created:
10 years ago by polina
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

ppapi_proxy: Make DebugPrintf more usable. Print to stdout to be consistent with PLUGIN_PRINTF. Always use a standardized prefix: -- Browser:: for browser-side functions -- Plugin:: for plugin-size functions -- PPB_... or PPP_... for implementations of PPAPI interfaces This makes it easier to great for slices of the logging info. Give fake_browser_ppapi its own version of DebugPrintf, always on. BUG=none TESTED=run_fake_browser_test_ppapi Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=3879

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -84 lines) Patch
M src/shared/ppapi_proxy/browser_instance.cc View 7 chunks +14 lines, -10 lines 0 comments Download
M src/shared/ppapi_proxy/browser_ppp.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M src/shared/ppapi_proxy/browser_upcall.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/shared/ppapi_proxy/plugin_core.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M src/shared/ppapi_proxy/plugin_instance.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/shared/ppapi_proxy/plugin_ppp_impl.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/shared/ppapi_proxy/plugin_var.cc View 12 chunks +21 lines, -16 lines 0 comments Download
M src/shared/ppapi_proxy/utility.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_core.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_file_io.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_file_io_trusted.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_file_ref.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_instance.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_object.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_url_loader.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_url_request_info.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_url_response_info.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/fake_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/fake_browser_ppapi/main.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M tests/fake_browser_ppapi/nacl.scons View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/fake_browser_ppapi/test_scriptable.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/fake_browser_ppapi/utility.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A tests/fake_browser_ppapi/utility.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
polina
10 years ago (2010-12-07 04:09:12 UTC) #1
sehr (please use chromium)
LGTM.
10 years ago (2010-12-07 19:50:56 UTC) #2
polina
10 years ago (2010-12-07 21:04:12 UTC) #3 
Thanks
Committed revision 3879

On 2010/12/07 19:50:56, sehr wrote:
> LGTM.

Powered by Google App Engine
This is Rietveld 408576698