V2 app support step3: Athena's NativeAppWindow

* Use componentized NativeAppWindowViews
* Factor out code that can be used for both chrome/app_shell version from athena/extensions/chrome
* Create AppsClient/AppsDelegate for app_shell version.
* Removed CreateAppsClient as it's no longer necessary.

AthenaNativeAppWindow needs more work in order to work properly on athena. I'll address them in separate bug/CLs.

BUG=410448, 410448
TBR=ben@chromium.org

Note: This CL depends on https://codereview.chromium.org/576863003/

Committed: https://crrev.com/03102bd6acd516669bd0c1fa45822a96475febd3
Cr-Commit-Position: refs/heads/master@{#295583}

[oshima, 2014-09-16 23:04:25]

Patchset #1 (id:1) has been deleted

[oshima, 2014-09-18 01:02:55]

Patchset #2 (id:10026) has been deleted

[oshima, 2014-09-18 01:02:58]

Patchset #1 (id:20001) has been deleted

[oshima, 2014-09-18 01:03:06]

Patchset #2 (id:70001) has been deleted

[oshima, 2014-09-18 01:03:14]

Patchset #1 (id:50001) has been deleted

[oshima, 2014-09-18 01:03:21]

Patchset #1 (id:90001) has been deleted

[oshima, 2014-09-18 01:03:29]

Patchset #1 (id:110001) has been deleted

[oshima, 2014-09-18 01:04:38]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-09-18 01:08:05]

oshima@chromium.org changed reviewers:
+ jamescook@chromium.org

[oshima, 2014-09-18 01:08:15]

Patchset #2 (id:150001) has been deleted

[oshima, 2014-09-18 01:08:21]

Patchset #1 (id:130001) has been deleted

[oshima, 2014-09-18 01:14:20]

mukai -> athena
jamescook -> extensions/shell

[Jun Mukai, 2014-09-18 17:38:05]

athena lgtm with nits

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/athen...
File athena/extensions/athena_native_app_window_views.cc (right):

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/athen...
athena/extensions/athena_native_app_window_views.cc:13: }  // namespace
namespace athena

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/chrom...
File athena/extensions/chrome/athena_chrome_apps_client.cc (right):

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/chrom...
athena/extensions/chrome/athena_chrome_apps_client.cc:14: //#include
"extensions/common/extension.h"
remove commented-out includes

[oshima, 2014-09-18 18:16:28]

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/athen...
File athena/extensions/athena_native_app_window_views.cc (right):

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/athen...
athena/extensions/athena_native_app_window_views.cc:13: }  // namespace
On 2014/09/18 17:38:05, Jun Mukai wrote:
> namespace athena

Done.

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/chrom...
File athena/extensions/chrome/athena_chrome_apps_client.cc (right):

https://codereview.chromium.org/563083003/diff/170001/athena/extensions/chrom...
athena/extensions/chrome/athena_chrome_apps_client.cc:14: //#include
"extensions/common/extension.h"
On 2014/09/18 17:38:05, Jun Mukai wrote:
> remove commented-out includes

Done.

[James Cook, 2014-09-18 19:08:26]

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
File extensions/shell/browser/shell_desktop_controller.cc (right):

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
extensions/shell/browser/shell_desktop_controller.cc:178:
extensions::AppsClient::Set(NULL);
nit: I would either move this to the end of this function (to allow
AppsClient::Get() in both the constructor and destructor), or move "new
AppsClient" to the end of the constructor and apps_client_.reset() here (to
disallow AppsClient::Get() in both the constructor and destructor).  I like init
and teardown order to match as exactly as possible.

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
File extensions/shell/browser/shell_desktop_controller.h (right):

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
extensions/shell/browser/shell_desktop_controller.h:132: scoped_ptr<AppsClient>
apps_client_;
hashimoto has a TODO in apps_client.h to rename it to AppWindowClient. Do you
think now is a good time to do that rename, given that you're introducing more
subclasses?

[oshima, 2014-09-18 20:56:50]

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
File extensions/shell/browser/shell_desktop_controller.cc (right):

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
extensions/shell/browser/shell_desktop_controller.cc:178:
extensions::AppsClient::Set(NULL);
On 2014/09/18 19:08:26, James Cook wrote:
> nit: I would either move this to the end of this function (to allow
> AppsClient::Get() in both the constructor and destructor), or move "new
> AppsClient" to the end of the constructor and apps_client_.reset() here (to
> disallow AppsClient::Get() in both the constructor and destructor).  I like
init
> and teardown order to match as exactly as possible.

Done.

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
File extensions/shell/browser/shell_desktop_controller.h (right):

https://codereview.chromium.org/563083003/diff/170001/extensions/shell/browse...
extensions/shell/browser/shell_desktop_controller.h:132: scoped_ptr<AppsClient>
apps_client_;
On 2014/09/18 19:08:26, James Cook wrote:
> hashimoto has a TODO in apps_client.h to rename it to AppWindowClient. Do you
> think now is a good time to do that rename, given that you're introducing more
> subclasses?

It requires touching more files, so let me create a separate CL.

[oshima, 2014-09-18 21:15:00]

Patchset #5 (id:250001) has been deleted

[James Cook, 2014-09-18 21:27:41]

LGTM

[oshima, 2014-09-18 21:31:01]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-18 21:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563083003/230001

[commit-bot: I haz the power, 2014-09-18 21:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 21:53:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2014-09-18 22:21:10]

oshima@chromium.org changed reviewers:
+ ben@chromium.org

[oshima, 2014-09-18 22:24:16]

tbr'ing ben for following deps in 

athena/extensions/DEPS

content/public/browser (simply moving from a/e/chrome/DEPS)
ui/aura
ui/gfx

[oshima, 2014-09-18 22:24:21]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-18 22:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563083003/230001

[commit-bot: I haz the power, 2014-09-18 22:34:25]

Committed patchset #4 (id:230001) as 5e686c07ae771ea23cf71e0207253eee7fee15dd

[commit-bot: I haz the power, 2014-09-18 22:35:04]

Patchset 4 (id:??) landed as
https://crrev.com/03102bd6acd516669bd0c1fa45822a96475febd3
Cr-Commit-Position: refs/heads/master@{#295583}