Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 563043005: Linux sandbox: move RestrictClockID() to sandbox/ (Closed)

Created:
6 years, 3 months ago by jln (very slow on Chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jln+watch_chromium.org, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: move RestrictClockID() to sandbox/ We move RestrictClockID() from the NaCl NonSFI sandbox to the main helpers in sandbox/. BUG=413469 TBR=brettw Committed: https://crrev.com/fcdfb1094c7db30011101c0442957b8e1b5252d1 Cr-Commit-Position: refs/heads/master@{#294533}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove test from Android. #

Patch Set 4 : Use DEATH_SEGV_MESSAGE in tests. #

Patch Set 5 : Add header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -82 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 2 chunks +4 lines, -61 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h View 1 chunk +9 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download
A sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 2 3 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jln (very slow on Chromium)
Matthew: PTAL!
6 years, 3 months ago (2014-09-11 23:50:07 UTC) #2
mdempsky_google
lgtm
6 years, 3 months ago (2014-09-11 23:55:12 UTC) #4
mdempsky
lgtm
6 years, 3 months ago (2014-09-12 00:16:41 UTC) #5
jln (very slow on Chromium)
TBR-ing brettw as third-party/ OWNERs which is required because I'm re-adding it to DEPS.
6 years, 3 months ago (2014-09-12 00:32:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563043005/70001
6 years, 3 months ago (2014-09-12 01:03:16 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:70001) as fd1f70b8511c7eeb4a2ecc3c568bee4dbf778d75
6 years, 3 months ago (2014-09-12 02:51:55 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 02:55:12 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fcdfb1094c7db30011101c0442957b8e1b5252d1
Cr-Commit-Position: refs/heads/master@{#294533}

Powered by Google App Engine
This is Rietveld 408576698