Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 562923002: Make host pairing screen the first screen for shark requisition. (Closed)

Created:
6 years, 3 months ago by achuithb
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make host pairing screen the first screen for shark requisition. With --show-host-pairing-demo and remora requisition, we start on the host pairing screen instead of the network screen. There's an issue with the host pairing screen not being ready to accept context changes. This is a temporary fix to get the end to end flow working. dzhioev@ will land a sequence of patches that are better long term. BUG=405150 TEST=manual Committed: https://crrev.com/5e1768a53d0abfb716997d91fbe7cc32d5ca6c8d Cr-Commit-Position: refs/heads/master@{#294513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
achuithb
Pavel, Zach, please review.
6 years, 3 months ago (2014-09-11 14:49:51 UTC) #2
Zachary Kuznia
lgtm
6 years, 3 months ago (2014-09-11 15:40:21 UTC) #3
dzhioev (left Google)
LGTM
6 years, 3 months ago (2014-09-11 17:05:06 UTC) #4
achuithb
On 2014/09/11 17:05:06, dzhioev wrote: > LGTM ty
6 years, 3 months ago (2014-09-11 22:53:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562923002/1
6 years, 3 months ago (2014-09-11 23:22:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as fe1ab805ab954a495454f0bb57e56e1c853813e8
6 years, 3 months ago (2014-09-12 00:59:05 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:02:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e1768a53d0abfb716997d91fbe7cc32d5ca6c8d
Cr-Commit-Position: refs/heads/master@{#294513}

Powered by Google App Engine
This is Rietveld 408576698