Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 562913002: Move web_request_condition* files to extensions/browser/api/declarative_webrequest/ (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, Xi Han, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move web_request_condition* files to extensions/browser/api/declarative_webrequest/ This is a simple move, except that we move three functions out of chrome/browser/extensions/api/web_request/web_request_api_helpers to extensions/browser/api/web_request/web_request_api_utils in order to remove the chrome/ dependency. A new namespace is introduced to avoid confusion. BUG=352293 . Committed: https://crrev.com/1b970299e390f8a5d7091ec888e1e7013731cffc Cr-Commit-Position: refs/heads/master@{#294437}

Patch Set 1 #

Patch Set 2 : Update extensions/BUILD.gn. #

Patch Set 3 : Remove unnecessary include. #

Patch Set 4 : Fix another BUILD.gn file. #

Patch Set 5 : Fix BUILD.gn some more. #

Patch Set 6 : Rebase to master@294403 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -2699 lines) Patch
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +0 lines, -275 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +0 lines, -878 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 chunk +0 lines, -719 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 1 chunk +0 lines, -397 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.h View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 3 chunks +0 lines, -62 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A extensions/browser/api/web_request/web_request_api_utils.h View 1 chunk +34 lines, -0 lines 0 comments Download
A extensions/browser/api/web_request/web_request_api_utils.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
wjmaclean
Fairly simple file move, please take a look?
6 years, 3 months ago (2014-09-11 14:46:49 UTC) #2
Ken Rockot(use gerrit already)
On 2014/09/11 14:46:49, wjmaclean wrote: > Fairly simple file move, please take a look? lgtm
6 years, 3 months ago (2014-09-11 16:08:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562913002/80001
6 years, 3 months ago (2014-09-11 16:49:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/65669) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54725) win_gpu ...
6 years, 3 months ago (2014-09-11 16:58:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562913002/100001
6 years, 3 months ago (2014-09-11 17:04:07 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 38e71095981ca42a44a04aada6a75b8aec9c44cd
6 years, 3 months ago (2014-09-11 18:59:57 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:25 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1b970299e390f8a5d7091ec888e1e7013731cffc
Cr-Commit-Position: refs/heads/master@{#294437}

Powered by Google App Engine
This is Rietveld 408576698