Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 562863002: Gardening: Revert "Use AudioStreamMonitor to control power save blocking." (Closed)

Created:
6 years, 3 months ago by loislo
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gardening: Revert "Use AudioStreamMonitor to control power save blocking." This reverts commit 484d29dcb45ca362fc9049c37dd3a51e11492f14. This patch made media/media-controller-playbackrate.html test crash on DEBUG. it crashes at content/browser/web_contents/web_contents_impl.cc:4296 on DCHECK Looks like AddMediaPlayerEntry was called twice for the same player_cookie It is not clear how it happens due to async nature of the notification. The author is sleeping at the moment, so I decided to roll back the patch. BUG= TBR=dalecurtis@chromium.org Committed: https://crrev.com/0381a74131887eb13b5d457cce756fb7066411ea Cr-Commit-Position: refs/heads/master@{#294370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -1066 lines) Patch
M chrome/browser/media/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/media/audio_stream_monitor.h View 6 chunks +24 lines, -64 lines 0 comments Download
A chrome/browser/media/audio_stream_monitor.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A + chrome/browser/media/audio_stream_monitor_unittest.cc View 8 chunks +58 lines, -77 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 5 chunks +88 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/browser/media/audio_stream_monitor.h View 1 chunk +0 lines, -153 lines 0 comments Download
D content/browser/media/audio_stream_monitor.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D content/browser/media/audio_stream_monitor_unittest.cc View 1 chunk +0 lines, -297 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 3 chunks +33 lines, -24 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 7 chunks +14 lines, -46 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 10 chunks +39 lines, -126 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +0 lines, -88 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/media_observer.h View 1 chunk +21 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/audio_output_controller.h View 5 chunks +7 lines, -15 lines 0 comments Download
M media/audio/audio_output_controller.cc View 5 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
loislo
6 years, 3 months ago (2014-09-11 08:48:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562863002/1
6 years, 3 months ago (2014-09-11 08:48:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/15211)
6 years, 3 months ago (2014-09-11 10:16:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562863002/1
6 years, 3 months ago (2014-09-11 10:21:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 78e91a8ed12501f8df63333c769d08a5e91a6d9d
6 years, 3 months ago (2014-09-11 10:59:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0381a74131887eb13b5d457cce756fb7066411ea Cr-Commit-Position: refs/heads/master@{#294370}
6 years, 3 months ago (2014-09-11 11:03:57 UTC) #9
DaleCurtis
Seems the BUG= got dropped when you reverted this. Did you remove that intentionally?
6 years, 3 months ago (2014-09-11 18:00:54 UTC) #10
loislo
On 2014/09/11 18:00:54, DaleCurtis wrote: > Seems the BUG= got dropped when you reverted this. ...
6 years, 3 months ago (2014-09-11 18:35:48 UTC) #11
DaleCurtis
Turns out the new DCHECKs were catching real bugs that prexisted my patch, https://codereview.chromium.org/564943002/ I'll ...
6 years, 3 months ago (2014-09-11 19:39:27 UTC) #12
loislo
great!!! :) On Thu Sep 11 2014 at 11:39:29 PM <dalecurtis@chromium.org> wrote: > Turns out ...
6 years, 3 months ago (2014-09-11 19:44:05 UTC) #13
DaleCurtis
6 years, 3 months ago (2014-09-12 17:03:36 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/569713002/ by dalecurtis@chromium.org.

The reason for reverting is: Bugs should be fixed now... will CQ this revert..

Powered by Google App Engine
This is Rietveld 408576698