Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: SConstruct

Issue 562853003: Make pnacl_generate_pexe=0 nonsfi_nacl=1 bitcode=1 work. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: more changes to get ARM linking. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pnacl/driver/pnacl-driver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index f6dbc26d47a2f84544481b79683a25371ce9223f..45541eb80d4eb832053c1082a9ae32ca40774c14 100755
--- a/SConstruct
+++ b/SConstruct
@@ -688,6 +688,9 @@ nonsfi_test_whitelist = set([
'run_stack_alignment_test',
'run_syscall_test',
'run_thread_test',
+
+ # TODO(uekawa): Enable exception test when implementation is ready.
+ 'run_exception_test', # TODO(uekawa): disable before submitting because it fails.
])
@@ -3021,8 +3024,11 @@ def AllowInlineAssembly(env):
# only current ARM toolchain. One day, we will have an ARM GCC
# toolchain, and we will no longer need to use inline assembly
# with PNaCl/Clang at all.
- if not (env.Bit('target_arm') or env.Bit('target_mips32')):
- return False
+ #
+ # For Non-SFI NaCl we use inline assembly in PNaCl/Clang.
+ if not (env.Bit('target_arm') or env.Bit('target_mips32')
+ or env.Bit('nonsfi_nacl')):
+ return False
# Inline assembly does not work in pexes.
if env.Bit('pnacl_generate_pexe'):
return False
« no previous file with comments | « no previous file | pnacl/driver/pnacl-driver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698