Issue 562853003: Make pnacl_generate_pexe=0 nonsfi_nacl=1 bitcode=1 work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 562853003: Make pnacl_generate_pexe=0 nonsfi_nacl=1 bitcode=1 work. (Closed)

Created:
6 years, 3 months ago by Junichi Uekawa

Modified:
4 years, 8 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Project:
nacl

Visibility:
Public.

More Reviews

Description

Make pnacl_generate_pexe=0 nonsfi_nacl=1 bitcode=1 work. Enough plumbing to get run_exception_test_irt compile and fail. ./scons -j20 --mode=dbg-host,nacl_irt_test bitcode=1 nonsfi_nacl=1 pnacl_generate_pexe=0 run_exception_test_irt use_newlib_nonsfi_loader=0 platform=arm ./scons -j20 --mode=dbg-host,nacl_irt_test bitcode=1 nonsfi_nacl=1 pnacl_generate_pexe=0 run_exception_test_irt use_newlib_nonsfi_loader=0 platform=x86-32 BUG=408879

Patch Set 1 #

Patch Set 2 : revised to compile with pnacl-generate-pexe=0, arm does not yet work #

Patch Set 3 : more changes to get ARM linking. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -7 lines)			Patch
M	SConstruct	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pnacl/driver/pnacl-driver.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	site_scons/site_tools/naclsdk.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/common/register_set.h	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	tests/exception_test/exception_test.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/exception_test/nacl.scons	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/pnacl_native_objects/nacl.scons	View		2 chunks	+5 lines, -0 lines	0 comments	Download