Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 562833002: Encrypted Media: Fix a typo in FileIOTest::MatchResult(). (Closed)

Created:
6 years, 3 months ago by xhwang
Modified:
6 years, 3 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Encrypted Media: Fix a typo in FileIOTest::MatchResult(). This typo could cause a false negative when we use EXPECT_FILE_READ(kSuccess, NULL, 0) This CL fixes the typo and all tests are still passing. Committed: https://crrev.com/1170df750e636430670f4f4006c9f5cf919c3129 Cr-Commit-Position: refs/heads/master@{#294507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/cdm/ppapi/cdm_file_io_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
PTAL
6 years, 3 months ago (2014-09-11 04:16:29 UTC) #2
ddorwin
lgtm
6 years, 3 months ago (2014-09-11 20:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562833002/1
6 years, 3 months ago (2014-09-11 21:31:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e5a8f1134d84a98412ab28c01d5cac526c1e821f
6 years, 3 months ago (2014-09-12 00:48:15 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 00:53:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1170df750e636430670f4f4006c9f5cf919c3129
Cr-Commit-Position: refs/heads/master@{#294507}

Powered by Google App Engine
This is Rietveld 408576698