Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 562813003: webkit: Remove run_http_server.* scripts. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, abarth-chromium, Avi (use Gerrit), darin (slow to review), jam, jochen (gone - plz use gerrit), ojan, pilgrim_google, scherkus (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

webkit: Remove run_http_server.* scripts. Looks like nobody is using this script? Checked in Chromium, Blink and Buildbot repos. BUG=338338 TEST=None R=dpranke@chromium.org Committed: https://crrev.com/a6ce1c30c6b82151b727055c751b1d0ac03ebc35 Cr-Commit-Position: refs/heads/master@{#294456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
D webkit/tools/layout_tests/run_http_server.bat View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/tools/layout_tests/run_http_server.py View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/tools/layout_tests/run_http_server.sh View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
tfarina
Is this OK now? (Side note: webkit/ is almost empty/gone now). Is it still helpful ...
6 years, 3 months ago (2014-09-11 03:10:21 UTC) #1
Dirk Pranke
On 2014/09/11 03:10:21, tfarina wrote: > Is this OK now? (Side note: webkit/ is almost ...
6 years, 3 months ago (2014-09-11 16:59:37 UTC) #2
jamesr
lgtm2, but could you please put directions for how to run the replacement in a ...
6 years, 3 months ago (2014-09-11 17:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562813003/1
6 years, 3 months ago (2014-09-11 19:05:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as c54e090e99c7242ded5dcb83ed24a0c6e30adf1d
6 years, 3 months ago (2014-09-11 20:25:19 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a6ce1c30c6b82151b727055c751b1d0ac03ebc35 Cr-Commit-Position: refs/heads/master@{#294456}
6 years, 3 months ago (2014-09-11 20:35:08 UTC) #8
scherkus (not reviewing)
On 2014/09/11 20:35:08, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-09-26 23:59:13 UTC) #9
scherkus (not reviewing)
Nevermind. Answer was in the code. Replacement command line: ./third_party/WebKit/Tools/Scripts/run-blink-httpd
6 years, 2 months ago (2014-09-27 00:01:01 UTC) #11
jamesr
6 years, 2 months ago (2014-09-27 00:03:57 UTC) #12
Message was sent while issue was closed.
Earlier I said:

On 2014/09/11 17:29:46, jamesr wrote:
> could you please put directions for how to run the replacement in a
> comment on this issue for folks trying to figure out what to do?  I don't know
> what it is offhand.

which didn't happen before landing, but you've now done so.  Thanks!

Powered by Google App Engine
This is Rietveld 408576698