Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 562803002: Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (Closed)

Created:
6 years, 3 months ago by boliu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, Ignacio Solla
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7 id:120001 of https://codereview.chromium.org/557593002/) Reason for revert: Suspected to break tough_video_cases. See crbug.com/412897 for details. BUG=412897 Original issue's description: > Clean up WebMediaPlayerAndroid needs_establish_peer_ > > needs_establish_peer_ has been used to skip actual estalishing a surface > texture peer based on many conditions. Not all places that modify > actually checks all these conditions so there are bound to be some bugs. > > This CL aims to tease out all these different conditions and put them in > a single function EstablishSurfaceTexturePeerIfNeeded. This function > should be called any time these conditions are changed. Makes for much > saner reading. > > BUG=412578 > > Committed: https://crrev.com/701cb640efb326aa107b5b0c25dcf91766fe765f > Cr-Commit-Position: refs/heads/master@{#294068} TBR=qinmin@chromium.org,avayvod@chromium.org,ycheo@chromium.org NOTREECHECKS=true NOTRY=true BUG=412578 Committed: https://crrev.com/515ae254a0c8a4b29f87606c3464373e3b81400b Cr-Commit-Position: refs/heads/master@{#294271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -52 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 2 chunks +6 lines, -10 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 13 chunks +64 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
boliu
Created Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_
6 years, 3 months ago (2014-09-11 00:23:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562803002/1
6 years, 3 months ago (2014-09-11 00:24:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as ae1f0dfb995334b25bb84b054228472860292e9f
6 years, 3 months ago (2014-09-11 00:37:07 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:39:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/515ae254a0c8a4b29f87606c3464373e3b81400b
Cr-Commit-Position: refs/heads/master@{#294271}

Powered by Google App Engine
This is Rietveld 408576698