Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 562763006: Add jsdoc to metadata files. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add jsdoc to metadata files. This patch resolves very old todos about missing descriptions of arguments of methods in the metadata directory. TEST=No change. Comments only. BUG=413100 Committed: https://crrev.com/ab46b5e758e9f1f60c2bddaa79b85d4415773529 Cr-Commit-Position: refs/heads/master@{#294357}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -160 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js View 23 chunks +72 lines, -70 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js View 1 10 chunks +38 lines, -38 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/function_parallel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/function_sequence.js View 6 chunks +11 lines, -11 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/id3_parser.js View 10 chunks +30 lines, -26 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@fukino: PTAL. Thanks.
6 years, 3 months ago (2014-09-11 07:14:09 UTC) #2
fukino
lgtm with tiny nits. Thanks! https://codereview.chromium.org/562763006/diff/1/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js File ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js (right): https://codereview.chromium.org/562763006/diff/1/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js#newcode46 ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js:46: * @param {function} errorCallback ...
6 years, 3 months ago (2014-09-11 07:20:31 UTC) #3
mtomasz
https://codereview.chromium.org/562763006/diff/1/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js File ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js (right): https://codereview.chromium.org/562763006/diff/1/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js#newcode46 ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js:46: * @param {function} errorCallback Error callback/ On 2014/09/11 07:20:30, ...
6 years, 3 months ago (2014-09-11 07:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562763006/20001
6 years, 3 months ago (2014-09-11 07:34:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dfde3eeb570f3b11a7aeea3a1c6fb0bd150426e1
6 years, 3 months ago (2014-09-11 08:32:25 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 08:35:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab46b5e758e9f1f60c2bddaa79b85d4415773529
Cr-Commit-Position: refs/heads/master@{#294357}

Powered by Google App Engine
This is Rietveld 408576698