Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 562763005: Hold a handle to the v8 context in PepperTryCatchVar. (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hold a handle to the v8 context in PepperTryCatchVar. It is safer to hold a handle to v8 context in PepperTryCatchVar than to try retrieving it again on destruction from the frame (through the plugin instance) which has a chance of being torn down. BUG=411445 Committed: https://crrev.com/85d12eb757f3d699ee20701905c0bd3a800255f7 Cr-Commit-Position: refs/heads/master@{#294288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M content/renderer/pepper/pepper_try_catch.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_try_catch.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years, 3 months ago (2014-09-10 23:53:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm.
6 years, 3 months ago (2014-09-11 00:00:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562763005/1
6 years, 3 months ago (2014-09-11 00:04:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b80daffbb4842cd11a6c0dc222657f9271cafea7
6 years, 3 months ago (2014-09-11 01:47:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:09:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85d12eb757f3d699ee20701905c0bd3a800255f7
Cr-Commit-Position: refs/heads/master@{#294288}

Powered by Google App Engine
This is Rietveld 408576698