[EasyUnlock] Port PermitMessage class to native code.

[EasyUnlock] Port PermitMessage class to native code.

BUG=412882
TEST=components_unittests
R=tengs@chromium.org

Committed: https://crrev.com/3ca088e1bf653a570216e7c092657acfc36cdb4a
Cr-Commit-Position: refs/heads/master@{#294939}

[Tim Song, 2014-09-12 00:25:21]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:14: // [ message version ] [ body
length ] [ JSON body ]
Mention that the JSON object has the data and permit_id fields.

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
nit: alignment

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:92: if (!body->GetString(kPermitIdKey,
&permit_id) || permit_id.empty()) {
The permit_id is optional. It's fine if the message doesn't have it. In the
protocol, only the first auth message fills this field in.

[Ilya Sherman, 2014-09-12 01:24:26]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:14: // [ message version ] [ body
length ] [ JSON body ]
On 2014/09/12 00:25:21, Tim Song wrote:
> Mention that the JSON object has the data and permit_id fields.

Done.

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
On 2014/09/12 00:25:21, Tim Song wrote:
> nit: alignment

How would you like me to change the alignment?

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:92: if (!body->GetString(kPermitIdKey,
&permit_id) || permit_id.empty()) {
On 2014/09/12 00:25:21, Tim Song wrote:
> The permit_id is optional. It's fine if the message doesn't have it. In the
> protocol, only the first auth message fills this field in.

Done.

[Tim Song, 2014-09-12 01:38:21]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
On 2014/09/12 01:24:26, Ilya Sherman wrote:
> On 2014/09/12 00:25:21, Tim Song wrote:
> > nit: alignment
> 
> How would you like me to change the alignment?

nudge it right one character.

[Ilya Sherman, 2014-09-12 17:36:11]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
On 2014/09/12 01:38:21, Tim Song wrote:
> On 2014/09/12 01:24:26, Ilya Sherman wrote:
> > On 2014/09/12 00:25:21, Tim Song wrote:
> > > nit: alignment
> > 
> > How would you like me to change the alignment?
> 
> nudge it right one character.

Hmm, that would make it appear to be within the parenthetical expression that
starts on the previous line, which is not the case.

[Tim Song, 2014-09-12 23:54:25]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
On 2014/09/12 17:36:10, Ilya Sherman wrote:
> On 2014/09/12 01:38:21, Tim Song wrote:
> > On 2014/09/12 01:24:26, Ilya Sherman wrote:
> > > On 2014/09/12 00:25:21, Tim Song wrote:
> > > > nit: alignment
> > > 
> > > How would you like me to change the alignment?
> > 
> > nudge it right one character.
> 
> Hmm, that would make it appear to be within the parenthetical expression that
> starts on the previous line, which is not the case.

Yeah, I see your point. Maybe add a left shift zero for parallelism?

[Tim Song, 2014-09-15 17:24:55]

Forgot to LGTM this.

[Ilya Sherman, 2014-09-15 22:25:13]

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
File components/proximity_auth/wire_message.cc (right):

https://codereview.chromium.org/562763004/diff/1/components/proximity_auth/wi...
components/proximity_auth/wire_message.cc:52:
static_cast<size_t>(serialized_message[2]);
On 2014/09/12 23:54:25, Tim Song wrote:
> On 2014/09/12 17:36:10, Ilya Sherman wrote:
> > On 2014/09/12 01:38:21, Tim Song wrote:
> > > On 2014/09/12 01:24:26, Ilya Sherman wrote:
> > > > On 2014/09/12 00:25:21, Tim Song wrote:
> > > > > nit: alignment
> > > > 
> > > > How would you like me to change the alignment?
> > > 
> > > nudge it right one character.
> > 
> > Hmm, that would make it appear to be within the parenthetical expression
that
> > starts on the previous line, which is not the case.
> 
> Yeah, I see your point. Maybe add a left shift zero for parallelism?

Done.

[Ilya Sherman, 2014-09-15 22:27:01]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-09-15 22:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562763004/60001

[commit-bot: I haz the power, 2014-09-16 00:22:38]

Committed patchset #4 (id:60001) as bd404940b299205b455a52f54db0106b6189ea65

[commit-bot: I haz the power, 2014-09-16 00:24:18]

Patchset 4 (id:??) landed as
https://crrev.com/3ca088e1bf653a570216e7c092657acfc36cdb4a
Cr-Commit-Position: refs/heads/master@{#294939}