Convert device::UsbConfigDescriptor and friends to structs.

Convert device::UsbConfigDescriptor and friends to structs.

These classes do not need to be classes and expecially don't need to be
abstract classes as this leads to a complicated implementation and
complicated tests. All USB devices no matter the platform will have the
same descriptor data.

This change follows the model of device::HidDeviceInfo.

BUG=

Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5
Cr-Commit-Position: refs/heads/master@{#294594}

[Reilly Grant (use Gerrit), 2014-09-10 21:44:47]

reillyg@chromium.org changed reviewers:
+ dgozman@chromium.org, rockot@chromium.org, rpaquay@chromium.org,
scheib@chromium.org

[Reilly Grant (use Gerrit), 2014-09-10 21:45:39]

reillyg@chromium.org changed reviewers:
+ pfeldman@chromium.org

[Reilly Grant (use Gerrit), 2014-09-10 22:02:16]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2014-09-11 00:23:06]

Patchset #1 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2014-09-11 00:24:17]

dgozman, pfeldman: Android DevTools changes.
rockot, rpaquay, scheib: Device and extension API changes.

[Reilly Grant (use Gerrit), 2014-09-11 00:38:56]

reillyg@chromium.org changed reviewers:
- scheib@chromium.org

[Reilly Grant (use Gerrit), 2014-09-11 00:39:51]

Removing scheib because while he's a nice guy and would love to review some of
my patches he isn't actually OWNER of any of it.

[dgozman, 2014-09-11 11:23:47]

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_browsertest.cc (right):

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_browsertest.cc:354:
bulk_in.maximum_packet_size = 512;
This was 1Mb before. Why did you change it? This could probably slow down some
tests.

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_device.cc (right):

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_device.cc:62: if
(interface.alternate_setting != 0 ||
Did you change the meaning of this field? If not, this should be
|interface.alternate_setting == 0|.

[Reilly Grant (use Gerrit), 2014-09-11 17:49:26]

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_browsertest.cc (right):

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_browsertest.cc:354:
bulk_in.maximum_packet_size = 512;
On 2014/09/11 11:23:47, dgozman wrote:
> This was 1Mb before. Why did you change it? This could probably slow down some
> tests.

1Mb is impossibly large for a USB device (USB 2.0 max 512B, USB 3.0 max 1kB). We
should be testing what happens when the ADB bridge needs to send a ZLP. I don't
believe we're ever hitting this in any of the test cases anyways.

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_device.cc (right):

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_device.cc:62: if
(interface.alternate_setting != 0 ||
On 2014/09/11 11:23:47, dgozman wrote:
> Did you change the meaning of this field? If not, this should be
> |interface.alternate_setting == 0|.

I didn't change the meaning. alternate_setting == 0 means this interface is the
primary setting. This code was making (and continues to make) the assumption
that the ADB interface will be the default and it will not need to issue a
SET_INTERFACE request.

[Ken Rockot(use gerrit already), 2014-09-11 20:02:14]

lgtm

[Reilly Grant (use Gerrit), 2014-09-12 01:00:19]

Added typedefs for interface and endpoint iterators to encourage the use of this
pattern over iterating by index.

[dgozman, 2014-09-12 11:03:34]

lgtm

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_device.cc (right):

https://codereview.chromium.org/562763002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_device.cc:62: if
(interface.alternate_setting != 0 ||
On 2014/09/11 17:49:26, reillyg wrote:
> On 2014/09/11 11:23:47, dgozman wrote:
> > Did you change the meaning of this field? If not, this should be
> > |interface.alternate_setting == 0|.
> 
> I didn't change the meaning. alternate_setting == 0 means this interface is
the
> primary setting. This code was making (and continues to make) the assumption
> that the ADB interface will be the default and it will not need to issue a
> SET_INTERFACE request.

Thanks for clarification, was not obvious to me.

[Reilly Grant (use Gerrit), 2014-09-12 14:52:10]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-12 14:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562763002/60001

[commit-bot: I haz the power, 2014-09-12 15:33:20]

Committed patchset #2 (id:60001) as b5a62f1c0f1792b69540afc40ecea06a48bbc70a

[commit-bot: I haz the power, 2014-09-12 15:46:27]

Patchset 2 (id:??) landed as
https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5
Cr-Commit-Position: refs/heads/master@{#294594}

[weitao, 2014-09-12 19:19:32]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/567003002/ by weitaosu@chromium.org.

The reason for reverting is: This broken the Linux ASan LSan Tests:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

Sample callstacks:

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc
(/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config
third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor
third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration()
device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*,
base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)
chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    #5 0xb38aebf in Run base/bind_internal.h:288:12
    #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void,
base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*,
base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void
(crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&,
base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid
(*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey*
const&, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, base::MessageLoopProxy*) base/bind_internal.h:927
    #7 0x2d58bff in Run base/callback.h:401:12
    #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char
const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:446:3
    #10 0x2ca629e in DeferOrRunPendingTask
base/message_loop/message_loop.cc:456:5
    #11 0x2ca629e in base::MessageLoop::DoWork()
base/message_loop/message_loop.cc:565
    #12 0x2c23ddf in
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
base/message_loop/message_pump_libevent.cc:232:21
    #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    #14 0x2ca39c4 in base::MessageLoop::Run()
base/message_loop/message_loop.cc:308:3
    #15 0x50fd018 in
content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*)
content/browser/browser_thread_impl.cc:190:3
    #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*)
content/browser/browser_thread_impl.cc:244:14
    #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:80:3
    #19 0x7f4d560a3e99 in start_thread
/build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc
(/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config
third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor
third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration()
device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*,
base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)
chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    #5 0xb38aebf in Run base/bind_internal.h:288:12
    #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void,
base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*,
base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void
(crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&,
base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid
(*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey*
const&, base::Callback\u003Cvoid
(std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>,
std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)>
const&, base::MessageLoopProxy*) base/bind_internal.h:927
    #7 0x2d58bff in Run base/callback.h:401:12
    #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char
const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:446:3
    #10 0x2ca629e in DeferOrRunPendingTask
base/message_loop/message_loop.cc:456:5
    #11 0x2ca629e in base::MessageLoop::DoWork()
base/message_loop/message_loop.cc:565
    #12 0x2c23ddf in
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
base/message_loop/message_pump_libevent.cc:232:21
    #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    #14 0x2ca39c4 in base::MessageLoop::Run()
base/message_loop/message_loop.cc:308:3
    #15 0x50fd018 in
content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*)
content/browser/browser_thread_impl.cc:190:3
    #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*)
content/browser/browser_thread_impl.cc:244:14
    #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:80:3
    #19 0x7f4aef980e99 in start_thread
/build/buildd/eglibc-2.15/nptl/pthread_create.c:308
.