Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 562693002: Move TestBookmarkClient into bookmarks namespace. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, sky
CC:
chromium-reviews, tfarina, James Su, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move TestBookmarkClient into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org TBR=joaodasilva@chromium.org Committed: https://crrev.com/51a9d86f69d3cb21ce386fc4e6847e28a88aac19 Cr-Commit-Position: refs/heads/master@{#294329}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : fix enhanced_bookmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -44 lines) Patch
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 3 chunks +2 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.h View 3 chunks +9 lines, -9 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
I will rebase when I get back home later tonight. PTAL. Thanks,
6 years, 3 months ago (2014-09-10 15:56:04 UTC) #1
sky
LGTM
6 years, 3 months ago (2014-09-10 16:13:54 UTC) #2
tfarina
TBRing Joao for components/policy.
6 years, 3 months ago (2014-09-11 02:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562693002/20001
6 years, 3 months ago (2014-09-11 02:25:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/13960) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/13886) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-11 02:35:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562693002/40001
6 years, 3 months ago (2014-09-11 02:41:56 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 23d4a6de4f3da7a67e70614d9bffd5454d6d9a4e
6 years, 3 months ago (2014-09-11 05:51:04 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 05:55:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51a9d86f69d3cb21ce386fc4e6847e28a88aac19
Cr-Commit-Position: refs/heads/master@{#294329}

Powered by Google App Engine
This is Rietveld 408576698