Tidy up ConsoleMessage callstack inclusion, fix Worker console crashes

Source/core/frame/ConsoleBase.cpp

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 85 matching lines @@
 void ConsoleBase::assertCondition(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> arguments, bool condition)
 {
     if (condition)
         return;
 
     internalAddMessage(AssertMessageType, ErrorMessageLevel, scriptState, arguments, true);
 }
 
 void ConsoleBase::count(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> arguments)
 {
-    RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStack(1));
+    RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(1));

[kozyatinskiy1, 2014/09/15 12:57:25]

createScriptCallStack(1) is equivalent createScriptCallStackForConsole(1). In
createScriptCallStackForConsole if console agent is enabled we will collect
maxStackSize frames otherwise only one frame will be collected but if we pass
one to createScriptCallStack then nothing will change in both cases - we always
collect one frame.
Why do we need this change?

[sof, 2014/09/15 13:09:32]

Let me answer that with a question :) Why do you not want count() to use the
*Console() version that internalAddMessage() uses? Simple and consistent, and
easier to live with should the *Console() behavior evolve, for instance.

[kozyatinskiy1, 2014/09/15 13:31:29]

Because in internalAddMessage in case of tracing message we want collect more
than one frame - 
ScriptCallStack::maxCallStackSizeToCapture. In this call we always collect one
frame and I think that we can not do check is console agent enabled or disabled.
Continue with question :)
Why do extra checking if it can be skipped?

[sof, 2014/09/15 13:44:18]

I don't understand why you want to optimize this.

[kozyatinskiy1, 2014/09/15 14:18:21]

We discussed this with @vsevik in patch:
https://chromiumcodereview.appspot.com/458253002/diff/1/Source/core/inspector...

I have only one consideration - getting a little faster and easier code.

     const ScriptCallFrame& lastCaller = callStack->at(0);
     // Follow Firebug's behavior of counting with null and undefined title in
     // the same bucket as no argument
     String title;
     arguments->getFirstArgumentAsString(title);
     String identifier = title.isEmpty() ? String(lastCaller.sourceURL() + ':' + String::number(lastCaller.lineNumber()))
         : String(title + '@');
 
     HashCountedSet<String>::AddResult result = m_counts.add(identifier);
     String message = title + ": " + String::number(result.storedValue->value);
 
     RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, DebugMessageLevel, message);
     consoleMessage->setType(CountMessageType);
     consoleMessage->setScriptState(scriptState);
+    consoleMessage->setCallStack(callStack.release());
     reportMessageToConsole(consoleMessage.release());
 }
 
 void ConsoleBase::markTimeline(const String& title)
 {
     timeStamp(title);
 }
 
 void ConsoleBase::profile(const String& title)
 {
@@ skipping 32 matching lines @@
 
     double startTime = it->value;
     m_times.remove(it);
 
     double elapsed = monotonicallyIncreasingTime() - startTime;
     String message = title + String::format(": %.3fms", elapsed * 1000);
 
     RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, DebugMessageLevel, message);
     consoleMessage->setType(TimeEndMessageType);
     consoleMessage->setScriptState(scriptState);
+    consoleMessage->setCallStack(createScriptCallStackForConsole(1));

[kozyatinskiy1, 2014/09/15 12:57:25]

I suppose we can replace createScriptCallStackForConsole(1) to
createScriptCallStack(1)

     reportMessageToConsole(consoleMessage.release());
 }
 
 void ConsoleBase::timeStamp(const String& title)
 {
     TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "TimeStamp", "data", InspectorTimeStampEvent::data(context(), title));
     // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeline migrates to tracing.
     InspectorInstrumentation::consoleTimeStamp(context(), title);
 }
 
@@ skipping 30 matching lines @@
 
     String message;
     bool gotStringMessage = arguments ? arguments->getFirstArgumentAsString(message) : false;
 
     RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, level, gotStringMessage? message : String());
     consoleMessage->setType(type);
     consoleMessage->setScriptState(scriptState);
     consoleMessage->setScriptArguments(arguments);
 
     size_t stackSize = printTrace ? ScriptCallStack::maxCallStackSizeToCapture : 1;
-    RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(stackSize));
-    consoleMessage->setCallStack(callStack);
-
+    consoleMessage->setCallStack(createScriptCallStackForConsole(stackSize));
     reportMessageToConsole(consoleMessage.release());
 }
 
 } // namespace blink