Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 562673003: Make media::WallClockTimeSource thread safe. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make media::WallClockTimeSource thread safe. Temporary measure until both Pipeline is reworked to provide a time estimate to the main thread and VideoRendererImpl's internal thread is eliminated. This is similar to the the locking currently present in AudioRendererImpl. BUG=412764 Committed: https://crrev.com/465cf3e643d44ce7176072bdbac1a9b03ac70514 Cr-Commit-Position: refs/heads/master@{#294207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/wall_clock_time_source.h View 3 chunks +7 lines, -0 lines 0 comments Download
M media/base/wall_clock_time_source.cc View 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
6 years, 3 months ago (2014-09-10 17:39:21 UTC) #2
xhwang
lgtm
6 years, 3 months ago (2014-09-10 18:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/562673003/1
6 years, 3 months ago (2014-09-10 18:38:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 78aaabeef255995f7d7414c2f66df899cd940fc0
6 years, 3 months ago (2014-09-10 19:18:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 19:27:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465cf3e643d44ce7176072bdbac1a9b03ac70514
Cr-Commit-Position: refs/heads/master@{#294207}

Powered by Google App Engine
This is Rietveld 408576698