Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: trunk/Source/modules/mediastream/MediaStreamTrack.cpp

Issue 562663002: Revert 181702 "Oilpan: Move MediaStreamSource, MediaStreamCompon..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/Source/modules/mediastream/MediaStreamTrack.cpp
===================================================================
--- trunk/Source/modules/mediastream/MediaStreamTrack.cpp (revision 181729)
+++ trunk/Source/modules/mediastream/MediaStreamTrack.cpp (working copy)
@@ -58,6 +58,7 @@
MediaStreamTrack::~MediaStreamTrack()
{
+ m_component->source()->removeObserver(this);
}
String MediaStreamTrack::kind() const
@@ -145,9 +146,9 @@
MediaStreamTrack* MediaStreamTrack::clone(ExecutionContext* context)
{
- MediaStreamComponent* clonedComponent = MediaStreamComponent::create(component()->source());
- MediaStreamTrack* clonedTrack = MediaStreamTrack::create(context, clonedComponent);
- MediaStreamCenter::instance().didCreateMediaStreamTrack(clonedComponent);
+ RefPtr<MediaStreamComponent> clonedComponent = MediaStreamComponent::create(component()->source());
+ MediaStreamTrack* clonedTrack = MediaStreamTrack::create(context, clonedComponent.get());
+ MediaStreamCenter::instance().didCreateMediaStreamTrack(clonedComponent.get());
return clonedTrack;
}
@@ -228,9 +229,7 @@
void MediaStreamTrack::trace(Visitor* visitor)
{
visitor->trace(m_registeredMediaStreams);
- visitor->trace(m_component);
EventTargetWithInlineData::trace(visitor);
- MediaStreamSource::Observer::trace(visitor);
}
} // namespace blink
« no previous file with comments | « trunk/Source/modules/mediastream/MediaStreamTrack.h ('k') | trunk/Source/modules/mediastream/RTCStatsRequestImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698