Source/core/html/HTMLFormControlElement.h - Issue 562653002: Do not reset mouse focus flag on keydown at anchor elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 562653002: Do not reset mouse focus flag on keydown at anchor elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add regression test (click-focus-keydown-no-ring) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormControlElement.h

diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h

index bc8f2e0555d4ba86be4dd792b2e5f11001cf3488..ce5a4fdd1d7f905b07fe2245bbb8da7bffab4cef 100644

--- a/Source/core/html/HTMLFormControlElement.h

+++ b/Source/core/html/HTMLFormControlElement.h

@@ -130,9 +130,9 @@ protected:

virtual bool isKeyboardFocusable() const OVERRIDE;

virtual bool shouldShowFocusRingOnMouseFocus() const;

virtual bool shouldHaveFocusAppearance() const OVERRIDE FINAL;

- virtual bool wasFocusedByMouse() const OVERRIDE;

- virtual void setWasFocusedByMouse(bool) OVERRIDE FINAL;

virtual void dispatchBlurEvent(Element* newFocusedElement) OVERRIDE;

+ virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType) OVERRIDE;

+ virtual void willCallDefaultEventHandler(const Event&) OVERRIDE FINAL;

virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE FINAL;

« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »