Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: Source/core/dom/Element.h

Issue 562653002: Do not reset mouse focus flag on keydown at anchor elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add regression test (click-focus-keydown-no-ring) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/click-focus-keydown-no-ring-expected.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index fb64837278900697da17f45ef294779fe910a99f..ac816ebab48251ef995a935a00673b9f16e38505 100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -376,7 +376,6 @@ public:
bool isFocusable() const;
virtual bool isKeyboardFocusable() const;
virtual bool isMouseFocusable() const;
- virtual void willCallDefaultEventHandler(const Event&) OVERRIDE FINAL;
virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType);
virtual void dispatchBlurEvent(Element* newFocusedElement);
void dispatchFocusInEvent(const AtomicString& eventType, Element* oldFocusedElement);
@@ -534,10 +533,6 @@ protected:
// e.g., HTMLOptionElement.
virtual bool rendererIsFocusable() const;
- // These methods are overridden by subclasses whose default focus appearance should not remain hidden on mouse focus.
- virtual bool wasFocusedByMouse() const { return false; }
- virtual void setWasFocusedByMouse(bool) { }
-
// classAttributeChanged() exists to share code between
// parseAttribute (called via setAttribute()) and
// svgAttributeChanged (called when element.className.baseValue is set)
« no previous file with comments | « LayoutTests/fast/events/click-focus-keydown-no-ring-expected.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698