Source/core/html/HTMLAnchorElement.h - Issue 562653002: Do not reset mouse focus flag on keydown at anchor elements

Side by Side Diff: Source/core/html/HTMLAnchorElement.h

Issue 562653002: Do not reset mouse focus flag on keydown at anchor elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add regression test (click-focus-keydown-no-ring) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLAnchorElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Simon Hausmann <hausmann@kde.org>	4 * (C) 2000 Simon Hausmann <hausmann@kde.org>

5 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	87

88 protected:	88 protected:

89 HTMLAnchorElement(const QualifiedName&, Document&);	89 HTMLAnchorElement(const QualifiedName&, Document&);

90	90

91 virtual void attributeWillChange(const QualifiedName&, const AtomicString& o ldValue, const AtomicString& newValue) OVERRIDE;	91 virtual void attributeWillChange(const QualifiedName&, const AtomicString& o ldValue, const AtomicString& newValue) OVERRIDE;

92 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;	92 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;

93 virtual bool supportsFocus() const OVERRIDE;	93 virtual bool supportsFocus() const OVERRIDE;

94	94

95 private:	95 private:

96 virtual bool shouldHaveFocusAppearance() const OVERRIDE FINAL;	96 virtual bool shouldHaveFocusAppearance() const OVERRIDE FINAL;

97 virtual bool wasFocusedByMouse() const OVERRIDE FINAL;	97 virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType) OVERR IDE;

98 virtual void setWasFocusedByMouse(bool) OVERRIDE FINAL;

99 virtual bool isMouseFocusable() const OVERRIDE;	98 virtual bool isMouseFocusable() const OVERRIDE;

100 virtual bool isKeyboardFocusable() const OVERRIDE;	99 virtual bool isKeyboardFocusable() const OVERRIDE;

101 virtual void defaultEventHandler(Event*) OVERRIDE FINAL;	100 virtual void defaultEventHandler(Event*) OVERRIDE FINAL;

102 virtual void setActive(bool = true) OVERRIDE FINAL;	101 virtual void setActive(bool = true) OVERRIDE FINAL;

103 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE FINAL;	102 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE FINAL;

104 virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL;	103 virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL;

105 virtual bool hasLegalLinkAttribute(const QualifiedName&) const OVERRIDE FINA L;	104 virtual bool hasLegalLinkAttribute(const QualifiedName&) const OVERRIDE FINA L;

106 virtual bool canStartSelection() const OVERRIDE FINAL;	105 virtual bool canStartSelection() const OVERRIDE FINAL;

107 virtual short tabIndex() const OVERRIDE FINAL;	106 virtual short tabIndex() const OVERRIDE FINAL;

108 virtual bool draggable() const OVERRIDE FINAL;	107 virtual bool draggable() const OVERRIDE FINAL;

(...skipping 14 matching lines...) Expand all Loading...
123 }	122 }

124	123

125 // Functions shared with the other anchor elements (i.e., SVG).	124 // Functions shared with the other anchor elements (i.e., SVG).

126	125

127 bool isEnterKeyKeydownEvent(Event*);	126 bool isEnterKeyKeydownEvent(Event*);

128 bool isLinkClick(Event*);	127 bool isLinkClick(Event*);

129	128

130 } // namespace blink	129 } // namespace blink

131	130

132 #endif // HTMLAnchorElement_h	131 #endif // HTMLAnchorElement_h

OLD	NEW