Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 562613002: Revert of ReReland ServiceWorkerCacheStorage::Keys function (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ReReland ServiceWorkerCacheStorage::Keys function (patchset #3 id:140001 of https://codereview.chromium.org/543093003/) Reason for revert: Linux Valgrind now passes but ChromeOS Valgrind doesn't. Looks like I need to do more on TearDown. Original issue's description: > ReReland ServiceWorkerCacheStorage::Keys function > > Suppression (error hash=#E226F7559AD360E7#): > For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports > { > <insert_a_suppression_name_here> > Memcheck:Leak > fun:_Znw* > fun:_ZN4base8internal20PostTaskAndReplyImpl16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEESA_ > fun:_ZN4base10TaskRunner16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_ > fun:_ZN10disk_cache15SimpleEntryImpl13CloseInternalEv > fun:_ZN10disk_cache15SimpleEntryImpl24RunNextOperationIfNeededEv > fun:_ZN10disk_cache15SimpleEntryImpl21DoomOperationCompleteERKN4base8CallbackIFviEEENS0_5StateEi > } > Original CL: https://codereview.chromium.org/477973002/ > Reland: https://codereview.chromium.org/528233003/ > > The SimpleCache backend wasn't given a chance to finish up a close operation before the IO messageloop closed at the end of functions. The tests now run the loop in TearDown. > > The original patch is PatchSet1 and the fix is PatchSet3. > > BUG=392621 > > Committed: https://crrev.com/bbfe6ce49b8e99b190085dffbf446b474c5f07ff > Cr-Commit-Position: refs/heads/master@{#294090} TBR=michaeln@chromium.org,horo@chromium.org NOTREECHECKS=true NOTRY=true BUG=392621 Committed: https://crrev.com/7f816aa8a8a8fb288f318aad593ed9f765e999f3 Cr-Commit-Position: refs/heads/master@{#294150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -346 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 4 chunks +0 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 11 chunks +38 lines, -213 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 7 chunks +22 lines, -104 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jkarlin
Created Revert of ReReland ServiceWorkerCacheStorage::Keys function
6 years, 3 months ago (2014-09-10 09:32:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/562613002/1
6 years, 3 months ago (2014-09-10 09:33:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b2c7badad6081b168bd359670a39f0c35f257db1
6 years, 3 months ago (2014-09-10 09:35:04 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:56:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f816aa8a8a8fb288f318aad593ed9f765e999f3
Cr-Commit-Position: refs/heads/master@{#294150}

Powered by Google App Engine
This is Rietveld 408576698