Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562543004: Check If ImageBuffer is allocated before proceeding. (Closed)

Created:
6 years, 3 months ago by sivag
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, blink-reviews-rendering, Rik, jbroman, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, danakj, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check If ImageBuffer is allocated before proceeding. This patch takes care of the left out places where newly created ImageBuffer is not validated. BUG=248420 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181936

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +2 lines, -0 lines 2 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sivag
Ptal..
6 years, 3 months ago (2014-09-10 17:30:46 UTC) #2
sivag
kbr@chromium.org: Please review the changes. senorblanco@chromium.org: Please review the changes.
6 years, 3 months ago (2014-09-12 05:30:06 UTC) #5
Stephen White
LGTM https://codereview.chromium.org/562543004/diff/1/Source/core/rendering/svg/RenderSVGResourceFilter.cpp File Source/core/rendering/svg/RenderSVGResourceFilter.cpp (right): https://codereview.chromium.org/562543004/diff/1/Source/core/rendering/svg/RenderSVGResourceFilter.cpp#newcode134 Source/core/rendering/svg/RenderSVGResourceFilter.cpp:134: if (!image) This change seems harmless, but note ...
6 years, 3 months ago (2014-09-12 19:12:20 UTC) #6
sivag
https://codereview.chromium.org/562543004/diff/1/Source/core/rendering/svg/RenderSVGResourceFilter.cpp File Source/core/rendering/svg/RenderSVGResourceFilter.cpp (right): https://codereview.chromium.org/562543004/diff/1/Source/core/rendering/svg/RenderSVGResourceFilter.cpp#newcode134 Source/core/rendering/svg/RenderSVGResourceFilter.cpp:134: if (!image) On 2014/09/12 19:12:20, Stephen White wrote: > ...
6 years, 3 months ago (2014-09-12 20:52:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562543004/1
6 years, 3 months ago (2014-09-12 20:53:24 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:37:50 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181936

Powered by Google App Engine
This is Rietveld 408576698