Issue 562543002: Revert "Switch inlining to use simplified instead of machine loads.", "Fix size_t to int conversion…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 562543002: Revert "Switch inlining to use simplified instead of machine loads.", "Fix size_t to int conversion… (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger, sigurds

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Switch inlining to use simplified instead of machine loads.", "Fix size_t to int conversion compile error." and "Add copy support in inliner.". This reverts commits r23813, r23805 and r23804 for Windows breakage. TBR=mstarzinger@chromium.org,sigurds@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23816

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -193 lines)			Patch
M	src/compiler/access-builder.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/compiler/access-builder.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/compiler/change-lowering-unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/compiler/generic-graph.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-graph.h	View	4 chunks	+4 lines, -10 lines	0 comments	Download
M	src/compiler/js-inlining.cc	View	7 chunks	+38 lines, -101 lines	0 comments	Download
M	src/compiler/machine-operator-reducer-unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/simplified-operator-reducer-unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/cctest/compiler/test-changes-lowering.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	test/cctest/compiler/test-js-constant-cache.cc	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	test/cctest/compiler/test-js-context-specialization.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/compiler/test-machine-operator-reducer.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	test/cctest/compiler/test-representation-change.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	test/cctest/compiler/test-run-inlining.cc	View	13 chunks	+13 lines, -26 lines	0 comments	Download
M	test/cctest/compiler/test-simplified-lowering.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23816.

Expand Messages | Collapse Messages