[DevTools] Unify workers and web contents handling in inspect_ui.

[DevTools] Unify workers and web contents handling in inspect_ui.

Next step is to treat service workers similar to shared workers.

BUG=none

Committed: https://crrev.com/bfb96fbd8e62b0ab326a871f434f08ce2cccc551
Cr-Commit-Position: refs/heads/master@{#294581}

[dgozman, 2014-09-10 15:37:58]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2014-09-10 15:37:59]

Take a look please.

[pfeldman, 2014-09-10 18:29:39]

Can we get vkuzkokov take a look first?

[dgozman, 2014-09-10 19:08:25]

dgozman@chromium.org changed reviewers:
+ vkuzkokov@chromium.org

[dgozman, 2014-09-10 19:08:25]

On 2014/09/10 18:29:39, pfeldman wrote:
> Can we get vkuzkokov take a look first?

Sure! Vlad, take a look please.

[vkuzkokov, 2014-09-11 11:46:10]

On 2014/09/10 19:08:25, dgozman wrote:
> On 2014/09/10 18:29:39, pfeldman wrote:
> > Can we get vkuzkokov take a look first?
> 
> Sure! Vlad, take a look please.

lgtm

[dgozman, 2014-09-11 11:46:55]

Pavel, ptal.

[pfeldman, 2014-09-11 17:53:05]

lgtm w/ nit

https://codereview.chromium.org/562513003/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_target_impl.cc (right):

https://codereview.chromium.org/562513003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_target_impl.cc:281: static
DevToolsTargetImpl::List EnumerateWebContentsTargets() {
- It is either namespace or static.
- anonymous namespace is already declared above.

[dgozman, 2014-09-12 10:54:29]

https://codereview.chromium.org/562513003/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_target_impl.cc (right):

https://codereview.chromium.org/562513003/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_target_impl.cc:281: static
DevToolsTargetImpl::List EnumerateWebContentsTargets() {
On 2014/09/11 17:53:05, pfeldman wrote:
> - It is either namespace or static.
> - anonymous namespace is already declared above.

Done.

[dgozman, 2014-09-12 10:55:39]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-12 10:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562513003/20001

[commit-bot: I haz the power, 2014-09-12 11:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 11:07:53]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2014-09-12 11:50:27]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-12 11:50:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562513003/20001

[commit-bot: I haz the power, 2014-09-12 12:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 12:01:07]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2014-09-12 13:26:49]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-09-12 13:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562513003/20001

[commit-bot: I haz the power, 2014-09-12 13:34:35]

Committed patchset #2 (id:20001) as 94b3380b0e3d018bb290cc0fa36d27cc55787969

[commit-bot: I haz the power, 2014-09-12 13:36:45]

Patchset 2 (id:??) landed as
https://crrev.com/bfb96fbd8e62b0ab326a871f434f08ce2cccc551
Cr-Commit-Position: refs/heads/master@{#294581}