Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2327)

Unified Diff: Source/modules/mediasource/MediaSource.cpp

Issue 562503002: MSE: Complete letting SourceBuffer begin to do initialization segment received algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@1of3sided_blink_websourcebufferclient_for_track_init_notifications
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | public/platform/WebSourceBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediasource/MediaSource.cpp
diff --git a/Source/modules/mediasource/MediaSource.cpp b/Source/modules/mediasource/MediaSource.cpp
index b532e860cf45ae39e372b654f46d766fcec58c42..7ae83f52003a4137ed9858d2f8629d76baeafd1c 100644
--- a/Source/modules/mediasource/MediaSource.cpp
+++ b/Source/modules/mediasource/MediaSource.cpp
@@ -155,8 +155,6 @@ SourceBuffer* MediaSource::addSourceBuffer(const String& type, ExceptionState& e
SourceBuffer* buffer = SourceBuffer::create(webSourceBuffer.release(), this, m_asyncEventQueue.get());
// 6. Add the new object to sourceBuffers and fire a addsourcebuffer on that object.
m_sourceBuffers->add(buffer);
- // FIXME: Remove the following once Chromium calls WebSourceBufferClient::InitSegmentReceived()
- setSourceBufferActive(buffer);
// 7. Return the new object to the caller.
return buffer;
@@ -484,8 +482,7 @@ bool MediaSource::isOpen() const
void MediaSource::setSourceBufferActive(SourceBuffer* sourceBuffer)
{
- if (m_activeSourceBuffers->contains(sourceBuffer))
- return;
+ ASSERT(!m_activeSourceBuffers->contains(sourceBuffer));
// https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#widl-MediaSource-activeSourceBuffers
// SourceBuffer objects in SourceBuffer.activeSourceBuffers must appear in
« no previous file with comments | « LayoutTests/TestExpectations ('k') | public/platform/WebSourceBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698