Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 562503002: MSE: Complete letting SourceBuffer begin to do initialization segment received algorithm (Closed)

Created:
6 years, 3 months ago by wolenetz
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, damienv1, gunsch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@1of3sided_blink_websourcebufferclient_for_track_init_notifications
Project:
blink
Visibility:
Public.

Description

MSE: Complete letting SourceBuffer begin to do initialization segment received algorithm This change is the third in a three-sided set of changes, and lets WebSourceBufferClient be the sole trigger for Blink adding a SourceBuffer into SourceBuffer.activeSourceBuffers. R=acolwell@chromium.org,philipj@opera.com,tkent@chromium.org TEST=No mediasource layout test regression BUG=249428, 397243 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181949

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : No-op rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M public/platform/WebSourceBuffer.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
wolenetz
PTAL @ PS1: acolwell@, philipj@: everything abarth@: OWNERS review for public/ This is third of ...
6 years, 3 months ago (2014-09-10 00:44:38 UTC) #1
philipj_slow
lgtm
6 years, 3 months ago (2014-09-10 13:14:18 UTC) #2
wolenetz
PS2 is just a rebase onto the updated (PS5) of part 1 of this 3-part ...
6 years, 3 months ago (2014-09-10 21:19:57 UTC) #3
philipj_slow
Still LGTM. If a rebase doesn't introduce any interesting changes, it's OK to go ahead ...
6 years, 3 months ago (2014-09-11 14:55:17 UTC) #4
wolenetz
Both abarth@ and jamesr@ have indicated their unavailability to CR the public/platform piece of this ...
6 years, 3 months ago (2014-09-11 23:12:41 UTC) #7
tkent
lgtm.
6 years, 3 months ago (2014-09-12 00:28:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562503002/60001
6 years, 3 months ago (2014-09-13 02:04:55 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 03:34:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181949

Powered by Google App Engine
This is Rietveld 408576698