Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 562493004: Clean up investigation code in DeleteHelper::DoDelete (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up investigation code in DeleteHelper::DoDelete Removing a local variable to keep it in the crash dump, that is added in: http://crrev.com/c7f0b95fefa64b7bb0accea8aafc3fb819bfdcc7 BUG=393634 Committed: https://crrev.com/34df520da32e17c95ccd4b17cb75cb8455b3d193 Cr-Commit-Position: refs/heads/master@{#294143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/sequenced_task_runner_helpers.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tzik
PTL.
6 years, 3 months ago (2014-09-10 01:04:22 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-09-10 03:37:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/562493004/1
6 years, 3 months ago (2014-09-10 03:58:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/10808)
6 years, 3 months ago (2014-09-10 06:51:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/562493004/1
6 years, 3 months ago (2014-09-10 07:09:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3151f26a7b0e60d218e6f1ffe71ff687ae630e76
6 years, 3 months ago (2014-09-10 08:17:45 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:56:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34df520da32e17c95ccd4b17cb75cb8455b3d193
Cr-Commit-Position: refs/heads/master@{#294143}

Powered by Google App Engine
This is Rietveld 408576698