Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562493002: Web Animations: Use an IDL enum for AnimationPlayState (Closed)

Created:
6 years, 3 months ago by dstockwell
Modified:
6 years, 3 months ago
CC:
dstockwell, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web Animations: Use an IDL enum for AnimationPlayState BUG=396366 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181698

Patch Set 1 #

Total comments: 2

Patch Set 2 : playing -> running #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/animation/AnimationPlayer.idl View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
alancutter (OOO until 2018)
lgtm after typo fix. https://codereview.chromium.org/562493002/diff/1/Source/core/animation/AnimationPlayer.idl File Source/core/animation/AnimationPlayer.idl (right): https://codereview.chromium.org/562493002/diff/1/Source/core/animation/AnimationPlayer.idl#newcode31 Source/core/animation/AnimationPlayer.idl:31: enum AnimationPlayState { "idle", "pending", ...
6 years, 3 months ago (2014-09-10 01:19:28 UTC) #2
dstockwell
https://codereview.chromium.org/562493002/diff/1/Source/core/animation/AnimationPlayer.idl File Source/core/animation/AnimationPlayer.idl (right): https://codereview.chromium.org/562493002/diff/1/Source/core/animation/AnimationPlayer.idl#newcode31 Source/core/animation/AnimationPlayer.idl:31: enum AnimationPlayState { "idle", "pending", "playing", "paused", "finished" }; ...
6 years, 3 months ago (2014-09-10 01:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/562493002/20001
6 years, 3 months ago (2014-09-10 02:50:33 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181698

Powered by Google App Engine
This is Rietveld 408576698