Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 56243003: Fix clang build (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M mojo/services/native_viewport/android/mojo_viewport.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/android/mojo_viewport.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
Committed patchset #1 manually as r232423 (presubmit successful).
7 years, 1 month ago (2013-11-01 17:25:25 UTC) #1
Ben Goodger (Google)
7 years, 1 month ago (2013-11-01 17:27:44 UTC) #2
lgtm


On Fri, Nov 1, 2013 at 10:25 AM, <abarth@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Committed patchset #1 manually as r232423 (presubmit successful).
>
> Description:
> Fix clang build
>
> TBR=ben@chromium.org
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=232423<https://src.chromium.org/viewvc/chrome?view=rev&revision=232423>
>
> Please review this at
https://codereview.chromium.**org/56243003/<https://codereview.chromium.org/5...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/src.git@master<https://chromium....
>
> Affected files (+9, -0 lines):
>   M mojo/services/native_viewport/**android/mojo_viewport.h
>   M mojo/services/native_viewport/**android/mojo_viewport.cc
>
>
> Index: mojo/services/native_viewport/**android/mojo_viewport.cc
> diff --git a/mojo/services/native_**viewport/android/mojo_**viewport.cc
> b/mojo/services/native_**viewport/android/mojo_**viewport.cc
> index 97357da18f77833e87dfeba13a90a6**4b4c9a30e7..**
> 39615669d9ff2285b355031f6b706f**2cfa2ead21 100644
> --- a/mojo/services/native_**viewport/android/mojo_**viewport.cc
> +++ b/mojo/services/native_**viewport/android/mojo_**viewport.cc
> @@ -14,6 +14,12 @@
>  namespace mojo {
>  namespace services {
>
> +MojoViewportInit::**MojoViewportInit() {
> +}
> +
> +MojoViewportInit::~**MojoViewportInit() {
> +}
> +
>  static jint Init(JNIEnv* env, jclass obj, jint jinit) {
>    MojoViewportInit* init = reinterpret_cast<**MojoViewportInit*>(jinit);
>    MojoViewport* viewport = new MojoViewport(init);
> Index: mojo/services/native_viewport/**android/mojo_viewport.h
> diff --git a/mojo/services/native_**viewport/android/mojo_**viewport.h
> b/mojo/services/native_**viewport/android/mojo_**viewport.h
> index 0236430c5accf7fdf447f537866740**bea2ea93d4..**
> f4dec2325ca39fc9f3bef8e505a1e1**e49ad85066 100644
> --- a/mojo/services/native_**viewport/android/mojo_**viewport.h
> +++ b/mojo/services/native_**viewport/android/mojo_**viewport.h
> @@ -20,6 +20,9 @@ namespace mojo {
>  namespace services {
>
>  struct MojoViewportInit {
> +  MojoViewportInit();
> +  ~MojoViewportInit();
> +
>    scoped_refptr<base::**SingleThreadTaskRunner> ui_runner;
>    base::WeakPtr<**NativeViewportAndroid> native_viewport;
>  };
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698