Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/request-worker.js

Issue 562413003: Request construction spec changes to use the 'used' flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed method name & step number fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/serviceworkers/Body.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/resources/request-worker.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/request-worker.js b/LayoutTests/http/tests/serviceworker/resources/request-worker.js
index 7f6908330f0723850b65fb4b4d975a7e92b74e0f..90d34dab17552d5b81d3c7d736c493db5ad17586 100644
--- a/LayoutTests/http/tests/serviceworker/resources/request-worker.js
+++ b/LayoutTests/http/tests/serviceworker/resources/request-worker.js
@@ -97,6 +97,10 @@ test(function() {
assert_equals(request1.mode, mode1 ? mode1 : 'cors', 'Request.mode should match');
METHODS.forEach(function(method2) {
MODES.forEach(function(mode2) {
+ // We need to construct a new request1 because as soon as it
+ // is used in a constructor it will be flagged as 'used',
+ // and we can no longer construct objects with it.
+ request1 = new Request(URL, init1);
var init2 = {};
if (method2 != undefined) { init2['method'] = method2; }
if (mode2 != undefined) { init2['mode'] = mode2; }
@@ -132,6 +136,7 @@ test(function() {
request1 = new Request(request1);
assert_equals(request1.credentials, credentials1 ? credentials1 : 'omit', 'Request.credentials should match');
CREDENTIALS.forEach(function(credentials2) {
+ request1 = new Request(URL, init1);
var init2 = {};
if (credentials2 != undefined) { init2['credentials'] = credentials2; }
request2 = new Request(request1, init2);
@@ -284,6 +289,21 @@ test(function() {
});
}, 'Request method names are normalized');
+
+test(function() {
+ var req = new Request(URL);
+ assert_false(req.bodyUsed,
+ "Request should not be flagged as used if it has not been consumed.");
+ var req2 = new Request(req);
+ assert_true(req.bodyUsed,
+ "Request should be flagged as used if it is used as a construction " +
+ "argument of another Request.");
+ assert_false(req2.bodyUsed,
+ "Request should not be flagged as used if it has not been consumed.");
+ assert_throws(new TypeError(), function() { new Request(req); },
+ "Request cannot be constructed with a request that has been flagged as used.");
+ }, 'Request construction behavior regarding "used" body flag and exceptions.');
+
async_test(function(t) {
var getContentType = function(headers) {
var content_type = '';
« no previous file with comments | « no previous file | Source/modules/serviceworkers/Body.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698