Request construction spec changes to use the 'used' flag.

Source/modules/serviceworkers/Request.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "Request.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/fetch/FetchUtils.h"
@@ skipping 28 matching lines @@
         m_webRequest->setHeader(key, value);
         return true;
     }
 
 private:
     WebServiceWorkerRequest* m_webRequest;
 };
 
 Request* createRequestWithRequestData(ExecutionContext* context, FetchRequestData* request, const RequestInit& init, FetchRequestData::Mode mode, FetchRequestData::Credentials credentials, ExceptionState& exceptionState)
 {
     // "6. Let |mode| be |init|'s mode member if it is present, and

[horo, 2014/09/12 04:55:56]

nit: Please increment the number.

[dmurph, 2014/09/12 18:40:08]

Done.

     // |fallbackMode| otherwise."
     // "7. If |mode| is non-null, set |request|'s mode to |mode|."

[horo, 2014/09/12 04:55:57]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     if (init.mode == "same-origin") {
         request->setMode(FetchRequestData::SameOriginMode);
     } else if (init.mode == "no-cors") {
         request->setMode(mode = FetchRequestData::NoCORSMode);
     } else if (init.mode == "cors") {
         request->setMode(FetchRequestData::CORSMode);
     } else {
         // Instead of using null as a special fallback value, we pass the
         // current mode in Request::create(). So we just set here.
         request->setMode(mode);
     }
 
     // "8. Let |credentials| be |init|'s credentials member if it is present,

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // and |fallbackCredentials| otherwise."
     // "9. If |credentials| is non-null, set |request|'s credentials mode to

[horo, 2014/09/12 04:55:57]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // |credentials|.
     if (init.credentials == "omit") {
         request->setCredentials(FetchRequestData::OmitCredentials);
     } else if (init.credentials == "same-origin") {
         request->setCredentials(FetchRequestData::SameOriginCredentials);
     } else if (init.credentials == "include") {
         request->setCredentials(FetchRequestData::IncludeCredentials);
     } else {
         // Instead of using null as a special fallback value, we pass the
         // current credentials in Request::create(). So we just set here.
         request->setCredentials(credentials);
     }
 
     // "10. If |init|'s method member is present, let |method| be it and run

[horo, 2014/09/12 04:55:57]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // these substeps:"
     if (!init.method.isEmpty()) {
         // "1. If |method| is not a useful method, throw a TypeError."
         if (!FetchUtils::isUsefulMethod(init.method)) {
             exceptionState.throwTypeError("'" + init.method + "' HTTP method is unsupported.");
             return 0;
         }
         if (!isValidHTTPToken(init.method)) {
             exceptionState.throwTypeError("'" + init.method + "' is not a valid HTTP method.");
             return 0;
         }
         // FIXME: "2. Add case correction as in XMLHttpRequest?"
         // "3. Set |request|'s method to |method|."
         request->setMethod(XMLHttpRequest::uppercaseKnownHTTPMethod(AtomicString(init.method)));
     }
     // "11. Let |r| be a new Request object associated with |request|, Headers

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // object."
     Request* r = Request::create(context, request);
 
     // "12. Let |headers| be a copy of |r|'s Headers object."

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:08]

Done.

     // "13. If |init|'s headers member is present, set |headers| to |init|'s

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // headers member."
     // We don't create a copy of r's Headers object when init's headers member
     // is present.
     Headers* headers = 0;
     if (!init.headers && init.headersDictionary.isUndefinedOrNull()) {
         headers = r->headers()->createCopy();
     }
     // "14. Empty |r|'s request's header list."

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:07]

Done.

     r->request()->headerList()->clearList();
 
     // "15. If |r|'s request's mode is no CORS, run these substeps:

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:08]

Done.

     if (r->request()->mode() == FetchRequestData::NoCORSMode) {
         // "1. If |r|'s request's method is not a simple method, throw a
         // TypeError."
         if (!FetchUtils::isSimpleMethod(r->request()->method())) {
             exceptionState.throwTypeError("'" + r->request()->method() + "' is unsupported in no-cors mode.");
             return 0;
         }
         // "Set |r|'s Headers object's guard to |request-no-CORS|.
         r->headers()->setGuard(Headers::RequestNoCORSGuard);
     }
 
     // "16. Fill |r|'s Headers object with |headers|. Rethrow any exceptions."

[horo, 2014/09/12 04:55:57]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     if (init.headers) {
         ASSERT(init.headersDictionary.isUndefinedOrNull());
         r->headers()->fillWith(init.headers.get(), exceptionState);
     } else if (!init.headersDictionary.isUndefinedOrNull()) {
         r->headers()->fillWith(init.headersDictionary, exceptionState);
     } else {
         ASSERT(headers);
         r->headers()->fillWith(headers, exceptionState);
     }
     if (exceptionState.hadException())
         return 0;
     // "17. If |init|'s body member is present, run these substeps:"

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:08]

Done.

     if (init.bodyBlobHandle) {
         // "1. Let |stream| and |Content-Type| be the result of extracting
         // |init|'s body member."
         // "2. Set |r|'s request's body to |stream|."
         // "3.If |Content-Type| is non-null and |r|'s request's header list
         //  contains no header named `Content-Type`, append
         // `Content-Type`/|Content-Type| to |r|'s Headers object. Rethrow any
         // exception."
         r->setBodyBlobHandle(init.bodyBlobHandle);
         if (!init.bodyBlobHandle->type().isEmpty() && !r->headers()->has("Content-Type", exceptionState)) {
             r->headers()->append("Content-Type", init.bodyBlobHandle->type(), exceptionState);
         }
         if (exceptionState.hadException())
             return 0;
     }
     // "18. Set |r|'s MIME type to the result of extracting a MIME type from

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:08]

Done.

     // |r|'s request's header list."
     // FIXME: We don't have MIME type in Request object yet.
 
     // "19. Return |r|."

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     return r;
 }
 
 } // namespace
 
 Request* Request::create(ExecutionContext* context, const String& input, ExceptionState& exceptionState)
 {
     return create(context, input, Dictionary(), exceptionState);
 }
 
 Request* Request::create(ExecutionContext* context, const String& input, const Dictionary& init, ExceptionState& exceptionState)
 {
     // "1. Let |request| be |input|'s associated request, if |input| is a

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:08]

Done.

     // Request object, and a new request otherwise."
     FetchRequestData* request(FetchRequestData::create(context));
     // "2. Set |request| to a restricted copy of itself."

[horo, 2014/09/12 04:55:56]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     request = request->createRestrictedCopy(context, SecurityOrigin::create(context->url()));
     // "5. If |input| is a string, run these substeps:"

[horo, 2014/09/12 04:55:57]

diito

[dmurph, 2014/09/12 18:40:09]

Done.

     // "1. Let |parsedURL| be the result of parsing |input| with entry settings
     // object's API base URL."
     KURL parsedURL = context->completeURL(input);
     // "2. If |parsedURL| is failure, throw a TypeError."
     if (!parsedURL.isValid()) {
         exceptionState.throwTypeError("Invalid URL");
         return 0;
     }
     // "3. Set |request|'s url to |parsedURL|."
     request->setURL(parsedURL);
     // "4. Set |fallbackMode| to CORS."
     // "5. Set |fallbackCredentials| to omit."
     return createRequestWithRequestData(context, request, RequestInit(context, init, exceptionState), FetchRequestData::CORSMode, FetchRequestData::OmitCredentials, exceptionState);
 }
 
 Request* Request::create(ExecutionContext* context, Request* input, ExceptionState& exceptionState)
 {
     return create(context, input, Dictionary(), exceptionState);
 }
 
 Request* Request::create(ExecutionContext* context, Request* input, const Dictionary& init, ExceptionState& exceptionState)
 {
-    // "1. Let |request| be |input|'s associated request, if |input| is a
+    // "1. If input is a Request object, run these substeps:"
+    // "  1. If input's used flag is set, throw a TypeError."
+    // "  2. Set input's used flag."
+    if (input->bodyUsed()) {
+        exceptionState.throwTypeError(
+            "Cannot construct a Request with a Request object that has already been used.");
+        return 0;
+    }
+    input->setUsed();
+    // "2. Let |request| be |input|'s associated request, if |input| is a
     // Request object, and a new request otherwise."
-    // "2. Set |request| to a restricted copy of itself."
+    // "3. Set |request| to a restricted copy of itself."
     FetchRequestData* request(input->request()->createRestrictedCopy(context, SecurityOrigin::create(context->url())));
-    // "3. Let |fallbackMode| be null."
-    // "4. Let |fallbackCredentials| be null."
+    // "4. Let |fallbackMode| be null."
+    // "5. Let |fallbackCredentials| be null."
     // Instead of using null as a special fallback value, just pass the current
     // mode and credentials; it has the same effect.
     const FetchRequestData::Mode currentMode = request->mode();
     const FetchRequestData::Credentials currentCredentials = request->credentials();
     return createRequestWithRequestData(context, request, RequestInit(context, init, exceptionState), currentMode, currentCredentials, exceptionState);
 }
 
 Request* Request::create(ExecutionContext* context, FetchRequestData* request)
 {
     Request* r = new Request(context, request);
@@ skipping 103 matching lines @@
 }
 
 void Request::trace(Visitor* visitor)
 {
     Body::trace(visitor);
     visitor->trace(m_request);
     visitor->trace(m_headers);
 }
 
 } // namespace blink