Request construction spec changes to use the 'used' flag.

Request construction spec changes to use the 'used' flag.

This adds the following behavior:
1. If input is a Request object, run these substeps:
  1. If input's used flag is set, throw a TypeError.
  2. Set input's used flag.

Outlined in this change:
https://github.com/whatwg/fetch/commit/a898f9a2941350aa625aa79b24673628ac2b2a8e#diff-1feda49b40370635faef8b655f144f64R2681

Spec:
http://fetch.spec.whatwg.org/#dom-request

BUG=413072
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181934

[dmurph, 2014-09-11 23:32:40]

dmurph@chromium.org changed reviewers:
+ horo@chromium.org, jsbell@chromium.org

[dmurph, 2014-09-11 23:32:41]

Horo,

PTAL, Here are the constructor and test changes to support the bodyUsed property
in the Request constructor.

Please verify that the unrelated test changes still successfully test the
original intended behavior.

Thanks!
Daniel

[horo, 2014-09-12 04:55:57]

lgtm with nits.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/Body.h (right):

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Body.h:56: void setUsed();
setBodyUsed()

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/Request.cpp (right):

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:49: // "6. Let |mode| be |init|'s mode
member if it is present, and
nit: Please increment the number.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:51: // "7. If |mode| is non-null, set
|request|'s mode to |mode|."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:64: // "8. Let |credentials| be
|init|'s credentials member if it is present,
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:66: // "9. If |credentials| is
non-null, set |request|'s credentials mode to
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:80: // "10. If |init|'s method member
is present, let |method| be it and run
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:96: // "11. Let |r| be a new Request
object associated with |request|, Headers
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:100: // "12. Let |headers| be a copy
of |r|'s Headers object."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:101: // "13. If |init|'s headers
member is present, set |headers| to |init|'s
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:109: // "14. Empty |r|'s request's
header list."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:112: // "15. If |r|'s request's mode
is no CORS, run these substeps:
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:124: // "16. Fill |r|'s Headers object
with |headers|. Rethrow any exceptions."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:136: // "17. If |init|'s body member
is present, run these substeps:"
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:152: // "18. Set |r|'s MIME type to
the result of extracting a MIME type from
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:156: // "19. Return |r|."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:169: // "1. Let |request| be |input|'s
associated request, if |input| is a
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:172: // "2. Set |request| to a
restricted copy of itself."
diito

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:174: // "5. If |input| is a string,
run these substeps:"
diito

[jsbell, 2014-09-12 17:14:51]

Can you tweak the CL summary/description to explain the change a bit more? e.g. 

> Add 'body used' flag to Request, and check/set in constructor
> 
> Blah blah was added to the spec. It's used blah blah blah
> blah blah blah blah blah.
>
> Spec is at http://....#request-whatever

Most people who read the commit log will be unfamiliar with
Fetch spec. Best case, they don't care. Worst case, they'll
looking for a change that broke tests or regressed performance;
the more details you give the easier it'll be for them to not
blame your change. :)

[dmurph, 2014-09-12 18:40:09]

Whoops, not sure why I didn't notice all the other numbers. Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/Body.h (right):

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Body.h:56: void setUsed();
On 2014/09/12 04:55:56, horo wrote:
> setBodyUsed()

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/Request.cpp (right):

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:49: // "6. Let |mode| be |init|'s mode
member if it is present, and
On 2014/09/12 04:55:56, horo wrote:
> nit: Please increment the number.

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:51: // "7. If |mode| is non-null, set
|request|'s mode to |mode|."
On 2014/09/12 04:55:57, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:64: // "8. Let |credentials| be
|init|'s credentials member if it is present,
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:66: // "9. If |credentials| is
non-null, set |request|'s credentials mode to
On 2014/09/12 04:55:57, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:80: // "10. If |init|'s method member
is present, let |method| be it and run
On 2014/09/12 04:55:57, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:96: // "11. Let |r| be a new Request
object associated with |request|, Headers
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:100: // "12. Let |headers| be a copy
of |r|'s Headers object."
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:101: // "13. If |init|'s headers
member is present, set |headers| to |init|'s
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:109: // "14. Empty |r|'s request's
header list."
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:112: // "15. If |r|'s request's mode
is no CORS, run these substeps:
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:124: // "16. Fill |r|'s Headers object
with |headers|. Rethrow any exceptions."
On 2014/09/12 04:55:57, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:136: // "17. If |init|'s body member
is present, run these substeps:"
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:152: // "18. Set |r|'s MIME type to
the result of extracting a MIME type from
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:156: // "19. Return |r|."
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:169: // "1. Let |request| be |input|'s
associated request, if |input| is a
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:172: // "2. Set |request| to a
restricted copy of itself."
On 2014/09/12 04:55:56, horo wrote:
> diito

Done.

https://codereview.chromium.org/562413003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/Request.cpp:174: // "5. If |input| is a string,
run these substeps:"
On 2014/09/12 04:55:57, horo wrote:
> diito

Done.

[dmurph, 2014-09-12 21:17:53]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2014-09-12 21:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562413003/20001

[commit-bot: I haz the power, 2014-09-12 21:24:01]

Committed patchset #2 (id:20001) as 181934