Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562413002: Adds (native) annotation to the display settings. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds (native) annotation to the display settings. BUG=409492 R=oshima@chromium.org TEST=ash_unittests, manually Committed: https://crrev.com/780827b616bfbda7c971979cd3bf2effab1d5acf Cr-Commit-Position: refs/heads/master@{#294662}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -2 lines) Patch
M ash/display/display_change_observer_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 1 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Jun Mukai
6 years, 3 months ago (2014-09-11 21:52:11 UTC) #1
Jun Mukai
ping?
6 years, 3 months ago (2014-09-12 16:23:08 UTC) #2
oshima
https://codereview.chromium.org/562413002/diff/1/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/562413002/diff/1/ash/display/display_change_observer_chromeos.cc#newcode91 ash/display/display_change_observer_chromeos.cc:91: } this should be mode.native = (ui_scales[i] == device_scale_factor()) ...
6 years, 3 months ago (2014-09-12 17:23:49 UTC) #3
Jun Mukai
https://codereview.chromium.org/562413002/diff/1/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/562413002/diff/1/ash/display/display_change_observer_chromeos.cc#newcode91 ash/display/display_change_observer_chromeos.cc:91: } On 2014/09/12 17:23:49, oshima wrote: > this should ...
6 years, 3 months ago (2014-09-12 18:50:56 UTC) #4
oshima
lgtm
6 years, 3 months ago (2014-09-12 20:13:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562413002/20001
6 years, 3 months ago (2014-09-12 20:21:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 47571240780c9403c8ccee69f763d2428e002d99
6 years, 3 months ago (2014-09-12 21:28:35 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:31:23 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/780827b616bfbda7c971979cd3bf2effab1d5acf
Cr-Commit-Position: refs/heads/master@{#294662}

Powered by Google App Engine
This is Rietveld 408576698