Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 562403002: Remove TargetedStyleRecalc runtime flag. (Closed)

Created:
6 years, 3 months ago by rune
Modified:
6 years, 3 months ago
CC:
abarth-chromium, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, jamesr, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove TargetedStyleRecalc runtime flag. The flag has had status=stable for more than 4 months. R=chrishtr@chromium.org,esprehn@chromium.org,abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182098

Patch Set 1 #

Patch Set 2 : Don't use the runtime flag in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -91 lines) Patch
M LayoutTests/fast/css/invalidation/targeted-attribute-style-invalidation.html View 1 1 chunk +4 lines, -25 lines 0 comments Download
M LayoutTests/fast/css/invalidation/targeted-class-style-invalidation.html View 1 1 chunk +4 lines, -25 lines 0 comments Download
M LayoutTests/fast/css/invalidation/targeted-id-style-invalidation.html View 1 1 chunk +4 lines, -25 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
rune
Depends on https://codereview.chromium.org/544163003
6 years, 3 months ago (2014-09-11 21:45:50 UTC) #1
rune
On 2014/09/11 at 21:45:50, rune wrote: > Depends on https://codereview.chromium.org/544163003 ... which has now landed.
6 years, 3 months ago (2014-09-12 17:13:04 UTC) #2
esprehn
lgtm
6 years, 3 months ago (2014-09-12 17:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562403002/20001
6 years, 3 months ago (2014-09-12 17:53:05 UTC) #5
rune
On 2014/09/12 at 17:53:05, commit-bot wrote: > CQ is trying da patch. Follow status at ...
6 years, 3 months ago (2014-09-12 18:00:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/15071)
6 years, 3 months ago (2014-09-12 18:03:06 UTC) #8
rune
@abarth: I need a review from a Source/web owner. Could you take a look?
6 years, 3 months ago (2014-09-15 07:44:06 UTC) #9
rune
On 2014/09/15 at 07:44:06, rune wrote: > @abarth: I need a review from a Source/web ...
6 years, 3 months ago (2014-09-15 07:44:31 UTC) #10
abarth-chromium
public/web LGTM
6 years, 3 months ago (2014-09-16 19:51:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562403002/20001
6 years, 3 months ago (2014-09-16 19:52:27 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 21:24:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182098

Powered by Google App Engine
This is Rietveld 408576698