Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 562393002: Remove unused chrome.screenlockPrivate methods (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused chrome.screenlockPrivate methods TEST=Tested that easy unlock still works BUG=None Committed: https://crrev.com/15ce5fef76770ea53948b6660cc67f7f21a60163 Cr-Commit-Position: refs/heads/master@{#295216}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -354 lines) Patch
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h View 2 chunks +0 lines, -71 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc View 3 chunks +0 lines, -181 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.h View 1 3 chunks +5 lines, -16 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.cc View 3 chunks +2 lines, -28 lines 0 comments Download
M chrome/common/extensions/api/screenlock_private.idl View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/test/data/extensions/api_test/screenlock_private/auth_type/test.js View 1 chunk +1 line, -9 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
tbarzic
kalman: owner for extensions code dzhioev: owner for login code
6 years, 3 months ago (2014-09-11 20:51:42 UTC) #2
tbarzic
6 years, 3 months ago (2014-09-11 21:20:07 UTC) #4
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-11 21:31:28 UTC) #5
Tim Song
lgtm
6 years, 3 months ago (2014-09-12 01:14:44 UTC) #6
tbarzic
Nikita, can you take a look at ui/login part (I need an owner approval)
6 years, 3 months ago (2014-09-16 17:56:08 UTC) #8
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-16 18:20:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562393002/20001
6 years, 3 months ago (2014-09-17 01:37:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562393002/20001
6 years, 3 months ago (2014-09-17 01:37:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6bf1122076834044433f7a78bdc091bdd7465ab4
6 years, 3 months ago (2014-09-17 02:19:52 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 02:20:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15ce5fef76770ea53948b6660cc67f7f21a60163
Cr-Commit-Position: refs/heads/master@{#295216}

Powered by Google App Engine
This is Rietveld 408576698