Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 562373002: Change keyboard animation. (Closed)

Created:
6 years, 3 months ago by rsadam
Modified:
6 years, 3 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change keyboard animation. BUG=355572 Committed: https://crrev.com/20814d26d33aeebea2b12f14b92a1b7e8f415168 Cr-Commit-Position: refs/heads/master@{#294647}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M ui/keyboard/keyboard_controller.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
rsadam
Hey Biao, PTAL!
6 years, 3 months ago (2014-09-11 20:22:03 UTC) #1
rsadam
+bshe as reviewer.
6 years, 3 months ago (2014-09-11 20:28:11 UTC) #3
bshe
On 2014/09/11 20:28:11, rsadam wrote: > +bshe as reviewer. lgtm do you mind to run ...
6 years, 3 months ago (2014-09-11 21:13:53 UTC) #4
rsadam
On 2014/09/11 21:13:53, bshe wrote: > On 2014/09/11 20:28:11, rsadam wrote: > > +bshe as ...
6 years, 3 months ago (2014-09-11 22:57:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562373002/1
6 years, 3 months ago (2014-09-11 23:22:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13495)
6 years, 3 months ago (2014-09-12 01:15:11 UTC) #9
rsadam
Filed crbug.com/413822 to follow-up on opacity zero issue.
6 years, 3 months ago (2014-09-12 18:25:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562373002/20001
6 years, 3 months ago (2014-09-12 18:30:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3211ab4a9ce4a7fb02a8da64a74e12d0b0833a10
6 years, 3 months ago (2014-09-12 20:27:46 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 20:31:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20814d26d33aeebea2b12f14b92a1b7e8f415168
Cr-Commit-Position: refs/heads/master@{#294647}

Powered by Google App Engine
This is Rietveld 408576698