Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 562353004: use OVERRIDE macro consistently in spdy_framer_test.cc (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
Reviewers:
Johnny, Ryan Hamilton, Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use OVERRIDE macro consistently in spdy_framer_test.cc Followup to CL 485833002, which mixed use of the OVERRIDE macro and bare override. BUG=400336 Committed: https://crrev.com/db3bbbfe84dd4caab3a266a91d1204c45fb6c901 Cr-Commit-Position: refs/heads/master@{#294645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/spdy/spdy_framer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Mostyn Bramley-Moore
@Johnny: can you please give this a thumbs-up?
6 years, 3 months ago (2014-09-11 20:21:34 UTC) #2
Bence
rch: PTAL. Mostyn: FYI Johnny has recently left the Chromium project.
6 years, 3 months ago (2014-09-12 17:38:49 UTC) #4
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-12 17:50:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562353004/1
6 years, 3 months ago (2014-09-12 17:51:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4078)
6 years, 3 months ago (2014-09-12 18:52:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562353004/1
6 years, 3 months ago (2014-09-12 20:10:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as cd76b1b2beb47fb60bb18ffcff7792e152358854
6 years, 3 months ago (2014-09-12 20:19:11 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 20:22:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db3bbbfe84dd4caab3a266a91d1204c45fb6c901
Cr-Commit-Position: refs/heads/master@{#294645}

Powered by Google App Engine
This is Rietveld 408576698