extensions/browser/api/extensions_api_client.h - Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/extensions_api_client.h

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/extensions_api_client.h

diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h

index 77fb90970e342ac0ab18533216673978f8ebf600..08c6e3196ddf3da9e940f3e2185c5d56fb91c110 100644

--- a/extensions/browser/api/extensions_api_client.h

+++ b/extensions/browser/api/extensions_api_client.h

@@ -24,6 +24,7 @@ class BrowserContext;

namespace extensions {

class AppViewGuestDelegate;

+class ExtensionOptionsGuest;

class ExtensionOptionsGuestDelegate;

class MimeHandlerViewGuest;

class MimeHandlerViewGuestDelegate;

@@ -64,8 +65,8 @@ class ExtensionsAPIClient {

// Returns a delegate for ExtensionOptionsGuest. The caller owns the returned

// ExtensionOptionsGuestDelegate.

- virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate()

- const;

+ virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate(

+ ExtensionOptionsGuest* guest) const;

// Creates a delegate for MimeHandlerViewGuest.

virtual scoped_ptr<MimeHandlerViewGuestDelegate>