Recognize Bigint setters and getters. This code will be removed when/if we change the fields to be …

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/class_finalizer.h"
@@ skipping 3257 matching lines @@
             node->scope()->LookupVariable(Symbols::TypeArgumentsParameter(),
                                           true);
         Value* element_type = Bind(new(I) LoadLocalInstr(*type_args_parameter));
         LocalVariable* length_parameter =
             node->scope()->LookupVariable(Symbols::Length(), true);
         Value* length = Bind(new(I) LoadLocalInstr(*length_parameter));
         CreateArrayInstr* create_array =
             new CreateArrayInstr(node->token_pos(), element_type, length);
         return ReturnDefinition(create_array);
       }
+      case MethodRecognizer::kBigint_getDigits: {
+        Value* receiver = Bind(BuildLoadThisVar(node->scope()));
+        LoadFieldInstr* load = new(I) LoadFieldInstr(
+            receiver,
+            Bigint::digits_offset(),
+            Type::ZoneHandle(I, Type::DynamicType()),
+            node->token_pos());
+        // TODO(srdjan): Make this kTypedDataUint32ArrayCid.
+        load->set_result_cid(kDynamicCid);

[regis, 2014/09/11 22:33:30]

Why can't you do it now?

[srdjan, 2014/09/11 22:44:20]

I must keep the type (passed to LoadFieldInstr) and the cid in sync. There is no
preallocated Type for Uint32Array.

[Florian Schneider, 2014/09/12 09:17:39]

I think it should just work to set result_cid, but leave the AbstractType
dynamic. We create CompileType just from cids also in the type propagator
(CompileType::FromCid) e.g. after a CheckClassInstr.

[srdjan, 2014/09/12 15:29:35]

Currently it throws an NPE. Will investigate in next CL.

[srdjan, 2014/09/18 16:12:54]

It throws an NPE because it is sometimes NULL and not always Uint32array. Will
modify libraries to guarantee that it is always Uint32Array

+        load->set_recognized_kind(kind);
+        return ReturnDefinition(load);
+      }
+      case MethodRecognizer::kBigint_getUsed: {
+        Value* receiver = Bind(BuildLoadThisVar(node->scope()));
+        LoadFieldInstr* load = new(I) LoadFieldInstr(
+            receiver,
+            Bigint::used_offset(),
+            Type::ZoneHandle(I, Type::SmiType()),
+            node->token_pos());
+        load->set_result_cid(kSmiCid);
+        load->set_recognized_kind(kind);
+        return ReturnDefinition(load);
+      }
+      case MethodRecognizer::kBigint_getNeg: {
+        Value* receiver = Bind(BuildLoadThisVar(node->scope()));
+        LoadFieldInstr* load = new(I) LoadFieldInstr(
+            receiver,
+            Bigint::neg_offset(),
+            Type::ZoneHandle(I, Type::BoolType()),
+            node->token_pos());
+        load->set_result_cid(kBoolCid);
+        load->set_recognized_kind(kind);
+        return ReturnDefinition(load);
+      }
       default:
         break;
     }
   }
   InlineBailout("EffectGraphVisitor::VisitNativeBodyNode");
   NativeCallInstr* native_call = new(I) NativeCallInstr(node);
   ReturnDefinition(native_call);
 }
 
 
@@ skipping 935 matching lines @@
   Report::MessageF(Report::kBailout,
                    Script::Handle(function.script()),
                    function.token_pos(),
                    "FlowGraphBuilder Bailout: %s %s",
                    String::Handle(function.name()).ToCString(),
                    reason);
   UNREACHABLE();
 }
 
 }  // namespace dart